Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix update screenshot action to account for existing screenshot #25190

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Apr 25, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

The update screenshots test had an issue where updating existing screenshots (as opposed to adding new screenshots) was not working as intended.

Given two test runner:

Runner A that updates Screenshot 1
Runner B that updates Screenshot 2

When the results from Runner A were added to the project, we got an updated Screenshot 1 and the old Screenshot 2.

When the results from Runner B were added to the project, we got an updated Screenshot 2 and an old Screenshot 1. The result is that the updated Screenshot 1 was overwritten by the old Screenshot 1 that got added from Runner B.


This new approach ensures that only the changed screenshots per-runner are added to the archive. The directory structure is preserved, so unzipping and moving the screenshots should allow screenshots to be merged without any conflicts.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi requested a review from a team as a code owner April 25, 2022 22:00
@liamdebeasi liamdebeasi merged commit ff1429b into main Apr 25, 2022
@liamdebeasi liamdebeasi deleted the fix-update-screenshot branch April 25, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant