fix(modal, popover): do not dismiss when ionDismiss is emitted

[liamdebeasi]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Build (npm run build) was run locally and any changes were pushed
• Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Issue URL: resolves #25124

Modal and popover listen for a generic ionDismiss event. This was added years ago, but the event itself has not been used for a long time:

ionic-framework/packages/ionic/src/modal/modal.tsx

Line 32 in bd5b673

@Listen('ionDismiss')

ionDismiss appears to have been added as a testing API during the early development of Ionic v4:

ionic-framework/packages/ionic/src/core-hn/comments-page.tsx

Line 12 in bd5b673

Ionic.emit(this, 'ionDismiss');

Perhaps it was indeed meant to be a public API, but it was never documented. We also have alternative means of dismissing a modal now, so I am not sure this code is even needed.

With the introduction of ionDismiss with ion-select, modals and popovers that contain a select are now dismissing when the ionDismiss event is emitted from ion-select.

What is the new behavior?

• ionDismiss is no longer listened for in a modal or popover.

Does this introduce a breaking change?

• Yes
• No

Other information