Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): ensure that only tab pages get added to the tab navigation stack #25045

Merged
merged 7 commits into from
Apr 12, 2022

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #24859

What is the new behavior?

  • This PR ensures that only IonTabs updated routeInfo to add the correct tab information. This treats IonTabs as the source of truth for which tab is active so IonRouter does not need to worry about that.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: vue @ionic/vue package label Apr 1, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review April 1, 2022 17:16
@liamdebeasi liamdebeasi requested a review from a team as a code owner April 1, 2022 17:16
@liamdebeasi
Copy link
Contributor Author

I am going to wait a few more days to allow for developer feedback before merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: vue, non-tab routes getting added to tabs location history
3 participants