Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(col): col no longer errors when running in non-browser environment #24603

Merged
merged 4 commits into from
Jan 19, 2022
Merged

fix(col): col no longer errors when running in non-browser environment #24603

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
063c43f
fix(col): SSR support for custom element builds
sean-perkins Jan 13, 2022
234a2d9
fix(col): add window undefined check
liamdebeasi Jan 19, 2022
0781482
Merge remote-tracking branch 'origin/main' into FW-537
liamdebeasi Jan 19, 2022
0d8dbf9
Merge remote-tracking branch 'origin/main' into FW-537
liamdebeasi Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/components/col/col.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { Component, ComponentInterface, Host, Listen, Prop, forceUpdate, h } fro
import { getIonMode } from '../../global/ionic-global';
import { matchBreakpoint } from '../../utils/media';

const win = window as any;
const SUPPORTS_VARS = !!(win.CSS && win.CSS.supports && win.CSS.supports('--a: 0'));
const win = (typeof (window as any) !== 'undefined') ? window as any : undefined;
const SUPPORTS_VARS = win && !!(win.CSS && win.CSS.supports && win.CSS.supports('--a: 0'));
const BREAKPOINTS = ['', 'xs', 'sm', 'md', 'lg', 'xl'];

@Component({
Expand Down