Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix issue https://github.com/ionic-team/ionic-framework/issues/24531 #24532

Closed
wants to merge 0 commits into from

Conversation

mixalbl4-127
Copy link

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@sean-perkins
Copy link
Contributor

Hello @mixalbl4-127 thanks for the PR!

Can you please take a moment to update the template to correctly reflect that you have:

  • Ran lint
  • Ran build
  • Indicate this is a bug fix
  • Reference the issue number this addresses
  • Describe previous behavior
  • Describe current behavior
  • Indicate if this is a breaking change

You will also need to update the commit message to follow our standards: https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#commit-message-guidelines

Something similar to:

fix(popover): use composed path for trigger element target

@mixalbl4-127 mixalbl4-127 force-pushed the main branch 4 times, most recently from 1bc0531 to 75501d0 Compare January 8, 2022 12:30
@github-actions github-actions bot removed the package: core @ionic/core package label Jan 8, 2022
@mixalbl4-127
Copy link
Author

@sean-perkins moved here: #24535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants