Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slides): update swiper instance after initialization #24257

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Nov 22, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

When having a swiper instance (ion-slides) in a modal, subsequent initializations of the component will fail to initialize swiper; resulting in a developer to manually call .update() at an unspecified time.

Github repo of issue: https://github.com/dtarnawsky/cs-ion-slides-bug

Issue Number: N/A

What is the new behavior?

Forces the swiper instance to update 20ms after the initialization callback. This causes event bindings and instantiation logic to correctly apply when having ion-slides in a modal.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Reverts #20899.

The original repo for that PR/issue is unavailable, attempted to create a new repo here: https://github.com/sean-perkins/ion-slides-issue.

I could see it making sense to leave the patch fix in this PR and later revert that commit after v6. Open to feedback 👍

@github-actions github-actions bot added the package: core @ionic/core package label Nov 22, 2021
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure this does not regress #20356? Whoops didn't see the bottom of your post. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants