fix(alert): allow 5.5 items to show in alert-mode select popup in md

[averyjohnston]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Build (npm run build) was run locally and any changes were pushed
• Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Issue Number: Resolves #23760

In md mode, alert-style ion-selects with more than 5 items don't look scrollable, due to the alert content having the height for exactly 5 items.

What is the new behavior?

• Alert content height increased to allow for 5.5 items (going off the MD spec item height of 48px). The cut-off item makes it clear that the list can be scrolled to reveal more items.

Does this introduce a breaking change?

• Yes
• No

Other information

[liamdebeasi]

Great job! One final thing: We try to word our commits such that they describe what issue was resolved rather than what changed in the code. So one way you could word this is:

fix(alert): made it easier to determine if an alert is scrollable in MD mode

However you want to word it is up to you, as long as we convey what issue got fixed.

[averyjohnston]

Great job! One final thing: We try to word our commits such that they describe what issue was resolved rather than what changed in the code.

🤔 The contributing doc says to do the reverse: https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#commit-message-guidelines

describe what the commit does, not what issue it relates to or fixes

[liamdebeasi]

Sorry that's what I meant -- My comment was worded in a confusing way. This PR makes it easier to tell if an alert is scrollable, so describing the commit in that manner is something we should shoot for. (At the end of the day it's not an exact science, so if you have a commit message that you think is descriptive for Ionic developers then that's fine).

Thanks for pointing that out!