Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slides): add IonicSlides module for Swiper migration, deprecate ion-slides #23844

Merged
merged 5 commits into from
Aug 31, 2021

Conversation

willmartian
Copy link
Contributor

@willmartian willmartian commented Aug 30, 2021

backports #23447

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Aug 30, 2021
@github-actions github-actions bot added package: angular @ionic/angular package package: react @ionic/react package package: vue @ionic/vue package labels Aug 31, 2021
@willmartian willmartian marked this pull request as ready for review August 31, 2021 12:09
@willmartian willmartian changed the title feat(slides): backport IonicSwiper modules from next feat(slides): add IonicSlides module for Swiper migration, deprecate ion-slides Aug 31, 2021
@willmartian willmartian merged commit 11fda41 into main Aug 31, 2021
@willmartian willmartian deleted the backport-swiper-migration branch August 31, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants