Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reorder-group): dragging reorder item to bottom no longer gives out of bounds index #23797

Merged
merged 1 commit into from
Aug 23, 2021
Merged

fix(reorder-group): dragging reorder item to bottom no longer gives out of bounds index #23797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions core/src/components/reorder-group/reorder-group.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,17 +245,16 @@ export class ReorderGroup implements ComponentInterface {

private itemIndexForTop(deltaY: number): number {
const heights = this.cachedHeights;
let i = 0;

// TODO: since heights is a sorted array of integers, we can do
// speed up the search using binary search. Remember that linear-search is still
// faster than binary-search for small arrays (<64) due CPU branch misprediction.
for (i = 0; i < heights.length; i++) {
for (let i = 0; i < heights.length; i++) {
if (heights[i] > deltaY) {
break;
return i;
}
}
return i;
return heights.length - 1;
}

/********* DOM WRITE ********* */
Expand Down