Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

picker-column detect pressed #23040

Closed
wants to merge 2 commits into from
Closed

Conversation

devinova
Copy link

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The picker's pull movement incorrectly calculates the drag speed. After dragging the mouse or finger, after holding down and stopping, the picker does not take the stop into account and calculates de speed incorrectly.

Issue Number: #23034

What is the new behavior?

After dragging the mouse or finger, after holding down and stopping, the picker must take the stop into account and calculate a lower drag speed

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Mar 12, 2021
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! There are two things that need to be revised in order for this PR to be accepted:

  1. Please run npm install --legacy-peer-deps in the core directory to get rid of these package-lock.json changes.
  2. We should try to find a way to fix this issue without using setTimeout. Using setTimeout here can lead to both performance and async issues that we would like to avoid. Are we able to use the velocityY value in detail to see if the users is moving their pointer fast enough to warrant selecting the item in the column?

@devinova devinova closed this Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants