Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(label): keep color when focused on a floating or stacked label #18576

Merged
merged 9 commits into from
Oct 7, 2020
Merged

fix(label): keep color when focused on a floating or stacked label #18576

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f0cf992
bug(label): keep color when focused
topalavlad Jun 19, 2019
8084299
Merge branch 'focused_label_keep_color' of https://github.com/topalav…
topalavlad Jun 27, 2019
30a35dc
bug(label): keep color when focused
topalavlad Jun 27, 2019
c0e6f07
Merge branch 'master' into focused_label_keep_color
topalavlad Jun 27, 2019
05cfefb
Merge branch 'master' into focused_label_keep_color
topalavlad Jul 2, 2019
bb2cd8c
Merge branch 'master' into pr/18576
brandyscarney Aug 18, 2020
2232899
fix(label): pass color up to item to set highlight color on focus
brandyscarney Aug 18, 2020
5c652b8
Merge branch 'master' into pr/18576
brandyscarney Sep 10, 2020
5ff7f6c
Merge branch 'master' into pr/18576
brandyscarney Oct 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/components/label/label.md.vars.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
$label-md-text-color: $text-color-step-600 !default;

/// @prop - Text color of the stacked/floating label when it is focused
$label-md-text-color-focused: ion-color(primary, base) !default;
$label-md-text-color-focused: null !default;

/// @prop - Line height of the label when the text wraps
$label-md-text-wrap-line-height: 1.5 !default;
Expand Down
4 changes: 4 additions & 0 deletions core/src/components/label/test/basic/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,10 @@
<ion-label position="stacked">Stacked</ion-label>
<ion-input></ion-input>
</ion-item>
<ion-item>
<ion-label position="stacked" color="danger">Stacked</ion-label>
<ion-input></ion-input>
</ion-item>
</ion-list>
</ion-content>

Expand Down