Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu-button): hide the menu button when the split pane is visible or auto hide is true #18564

Closed
wants to merge 7 commits into from
Closed

fix(menu-button): hide the menu button when the split pane is visible or auto hide is true #18564

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
af69405
feat(split-pane): Hide the menu button when split pane is visible
mlynch Jun 18, 2019
c923ca8
Merge branch 'master' into hide-menu-button-split-pane
brandyscarney Jun 21, 2019
5b8737f
Merge branch 'master' into hide-menu-button-split-pane
brandyscarney Jul 1, 2019
f336322
test(menu-button): add a menu button that auto hides
brandyscarney Jul 1, 2019
22c0a9b
revert(split-pane): revert hiding menu button with visible split pane
brandyscarney Jul 2, 2019
84cc01c
fix(menu-button): hide menu button when toggle hides
brandyscarney Jul 2, 2019
b609b26
Update core/src/components/menu-button/menu-button.tsx
brandyscarney Jul 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/src/components/split-pane/split-pane.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,7 @@ ion-split-pane {
.split-pane-visible > .split-pane-side[side=end] {
order: 1;
}

.split-pane-visible ion-menu-button {
display: none;
}