-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rtl): enable ltr default, rtl selectors #16987
Conversation
I thought RTL styles won't be included by default anymore? An idea would be to put them in an optional CSS file. Sorry if I misunderstood :-) |
@abennouna With shadow dom it's proving to be challenging to have an optional css file for RTL, since certain parts of the components would not be able to easily know the Would you be able to pull down this branch and test it out? |
core/src/themes/ionic.mixins.scss
Outdated
} | ||
-webkit-padding-start: $start; | ||
padding-inline-start: $start; | ||
-webkit-padding-end: $end; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-webkit-padding-end: $end; | |
-webkit-#{$prop}-end: $end; |
Co-Authored-By: adamdbradley <[email protected]>
Co-Authored-By: adamdbradley <[email protected]>
Co-Authored-By: adamdbradley <[email protected]>
Co-Authored-By: adamdbradley <[email protected]>
i see greate work both of you making here |
No description provided.