-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(input): fix display of ion-input in narrow ion-item in Firefox #16978
Conversation
I just tested with the latest |
@pwespi Thanks for the PR! Could you add a code example to one of the e2e tests? Maybe this one: https://github.com/ionic-team/ionic/blob/master/core/src/components/input/test/basic/index.html That will make it easy for us to test it out and make sure it doesn't have a regression in the future. 🙂 |
Also, here are some docs on previewing changes if you need them: https://github.com/ionic-team/ionic/blob/master/.github/CONTRIBUTING.md#preview-changes |
test(input): add narrow input test
@brandyscarney I have added a code example. |
@pwespi Thanks for adding the code example and for the fix! Once the build finishes I can merge this. 🙂 |
Short description of what this resolves:
fix display of ion-input in narrow ion-item in Firefox
Ionic Version: 4
Fixes: #16977