Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): fix display of ion-input in narrow ion-item in Firefox #16978

Merged
merged 6 commits into from
Jan 15, 2019

Conversation

pwespi
Copy link
Contributor

@pwespi pwespi commented Jan 6, 2019

Short description of what this resolves:

fix display of ion-input in narrow ion-item in Firefox

Ionic Version: 4

Fixes: #16977

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Jan 6, 2019
@manucorporat
Copy link
Contributor

cc @brandyscarney

@pwespi
Copy link
Contributor Author

pwespi commented Jan 15, 2019

I just tested with the latest @ionic/core@dev and the issue is still there.
This PR should still work.

@brandyscarney
Copy link
Member

@pwespi Thanks for the PR! Could you add a code example to one of the e2e tests? Maybe this one: https://github.com/ionic-team/ionic/blob/master/core/src/components/input/test/basic/index.html

That will make it easy for us to test it out and make sure it doesn't have a regression in the future. 🙂

@brandyscarney
Copy link
Member

Also, here are some docs on previewing changes if you need them: https://github.com/ionic-team/ionic/blob/master/.github/CONTRIBUTING.md#preview-changes

test(input): add narrow input test
@pwespi
Copy link
Contributor Author

pwespi commented Jan 15, 2019

@brandyscarney I have added a code example.
Note that the issue only occurs in Firefox (tested on Windows 10, Firefox 64.0.2)

@brandyscarney
Copy link
Member

brandyscarney commented Jan 15, 2019

@pwespi Thanks for adding the code example and for the fix! Once the build finishes I can merge this. 🙂

@brandyscarney brandyscarney merged commit 1099dc3 into ionic-team:master Jan 15, 2019
@pwespi pwespi deleted the fix-input branch January 16, 2019 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants