Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1464 ngValue uses a value instead of variable #1500

Closed
wants to merge 1 commit into from
Closed

#1464 ngValue uses a value instead of variable #1500

wants to merge 1 commit into from

Conversation

ericwooley
Copy link

#1464

ng-value was being scoped as a variable by ion-radio, which would have required you to basically enumerate the values in your $scope and set them using ng-value='someScopeVaraible'

@perrygovier
Copy link
Contributor

Andy, can you confirm this works as intended?

@perrygovier
Copy link
Contributor

Duplicate of #1464

@ajoslin
Copy link
Contributor

ajoslin commented May 27, 2014

This is correct. I'll add a unit test and merge.

@ajoslin
Copy link
Contributor

ajoslin commented May 27, 2014

Merged.

@ajoslin ajoslin closed this May 27, 2014
@ajoslin
Copy link
Contributor

ajoslin commented May 27, 2014

Thanks @ericwooley !

@ericwooley
Copy link
Author

No problem! This was my first contribution to a FOSS project. I am looking forward to contributing more.

Awesome project by the way, I made an app over the weekend that I am already getting ready to launch. Using ionic is awesome and made it the entire process so much easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants