Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow ion-item <a target> assignment #1492

Closed
wants to merge 1 commit into from
Closed

allow ion-item <a target> assignment #1492

wants to merge 1 commit into from

Conversation

leefernandes
Copy link

default to _self

allow <a target> assignment
8d4dede 
default to _self
@leefernandes leefernandes changed the title allow <a target> assignment allow ion-item <a target> assignment May 24, 2014
@perrygovier
Copy link
Contributor

This looks straight forward enough.

Note for the cordova inAppBrowser plugin (a common use for special targets, you'll want to use an ng-click with window.open on most platforms.

@ajoslin
Copy link
Contributor

ajoslin commented May 27, 2014

LGTM

@perrygovier perrygovier reopened this May 28, 2014
@perrygovier
Copy link
Contributor

wrong PR, lets try that again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ajoslin ajoslin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leefernandes @perrygovier @ajoslin