Fixing requestAnimationFrame & cancelAnimationFrame #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the previous implementation, Chrome complains:
"'webkitCancelAnimationFrame' is vendor-specific. Please use the standard 'cancelAnimationFrame' instead."
This fixes that by reusing (copy-paste) the code from angular.js
A better way would be to use ionic.requestAnimationFrame and ionic.cancelAnimationFrame everywhere, but that is more involved and risky...
|
LGTM. @adamdbradley? |
adamdbradley
added a commit
that referenced
this pull request
Jun 6, 2014
fix(rAF): fixing requestAnimationFrame & cancelAnimationFrame
|
Thanks! |
ajoslin
added a commit
that referenced
this pull request
Jun 16, 2014
A pull request (#1430) was merged that added a requestAnimationFrame polyfill to the window on platforms that do not have rAF. This was overlooked. This now has created conflicts with Angular 1.2.17 on Android browsers that do not have requestAnimationFrame. The problem was that a polyfill for requestAnimationFrame was put onto the window for Android <4.3. AngularJS would then check if window.requestAnimationFrame existed. Angular's check passed, and then it would try to use cancelAnimationFrame which was undefined. Now, nothing on the window is changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the previous implementation, Chrome complains:
"'webkitCancelAnimationFrame' is vendor-specific. Please use the standard 'cancelAnimationFrame' instead."
This fixes that by reusing (copy-paste) the code from angular.js
A better way would be to use ionic.requestAnimationFrame and ionic.cancelAnimationFrame everywhere, but that is more involved and risky...