Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(infinite-scroll): properly updates scrollTop of ion-content #12599

Closed
wants to merge 91 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
91 commits
Select commit Hold shift + click to select a range
a91a68e
style(util): remove commented out test css
brandyscarney Jun 12, 2017
47e3c70
fix(refresher): border should only show when pulled (#12015)
Manduro Jun 12, 2017
c10f72b
fix(keyboard): big keyboard/input refactor
manucorporat Jun 7, 2017
6dee17b
Merge branch 'keyboard-fixes'
manucorporat Jun 12, 2017
ef85ba6
fix(input): add correct translate3d for rtl
manucorporat Jun 12, 2017
8041eed
fix(input): use all supported attributes on both textareas and inputs…
Manduro Jun 13, 2017
9f86e10
fix(input): better handling of attributes
manucorporat Jun 13, 2017
dc958c3
fix(textarea): apply classes properly
manucorporat Jun 13, 2017
54ac2e3
fix(input): slightly longer delay for autofocus (#12037)
Manduro Jun 14, 2017
2791c40
chore(changelog): 3.4.0 release
danbucholtz Jun 15, 2017
f149c5e
chore(dependencies): update package version to 3.4.0
danbucholtz Jun 15, 2017
3564bcf
chore(github): update issue template plunkr to 3.4.0 version
danbucholtz Jun 15, 2017
7a1342c
fix(input): prevent duplicated tabIndex (#12043)
manucorporat Jun 15, 2017
2743c63
refactor(overlay): simplify focusOutActiveElement (#12023)
manucorporat Jun 15, 2017
c7645ee
feat(select): add compareWith Input for object value comparison (#11965)
zakton5 Jun 15, 2017
5a5da39
fix(highlight): selected tab might be null
manucorporat Jun 15, 2017
1a4aacf
chore(changelog): add upgrade instructions for 3.4.0
danbucholtz Jun 15, 2017
6193560
fix(sliding-item): super slow device does get correct classes
manucorporat Jun 15, 2017
63f728f
feat(item-reorder): add side support (#11642)
AmitMY Jun 15, 2017
8bd2f24
perf(item): button-effect is hidden for non buttons
manucorporat May 5, 2017
7803998
style(reorder): using const
manucorporat Jun 15, 2017
a8731df
fix(tabs): properly align tabs highlight (#11619)
dudeofawesome Jun 15, 2017
877d821
chore(changelog): fix typo, update deps to latest
danbucholtz Jun 16, 2017
1ca7df7
fix(themes): change default app-direction
brandyscarney Jun 16, 2017
5094fee
chore(ionic): release 3.4.1
brandyscarney Jun 16, 2017
70b5b6b
fix(rtl): use multi direction in order to override the default ltr
brandyscarney Jun 16, 2017
d8b65da
chore(ionic): release 3.4.2
brandyscarney Jun 16, 2017
e3a8d27
fix(select): floating label
manucorporat Jun 19, 2017
5cad965
feature(navigation): modify urls to support multiple root level navs/…
danbucholtz Jun 19, 2017
00fbded
chore(build): strictly enforce metadata
danbucholtz Jun 19, 2017
bcc85d9
chore(build): fix path issue in snapshot test
danbucholtz Jun 19, 2017
6f7acdb
docs(changelog): fix broken commit links
brandyscarney Jun 20, 2017
f39c381
fix(navigation): add isTab check to getSegmentsFromNav
danbucholtz Jun 20, 2017
0480f73
chore(nav): fix lint errors in test
danbucholtz Jun 20, 2017
58e1d79
refactor(app): refactor app slightly to maintain backwards compatibility
danbucholtz Jun 20, 2017
1beef75
refactor(navigation): refactor nav-controller-base to maintain backwa…
danbucholtz Jun 20, 2017
30f69c8
fix(navigation): fallback to name if component does not exist on segment
danbucholtz Jun 20, 2017
fba6ff0
add href for additional testing
danbucholtz Jun 20, 2017
86495e1
docs(api): angularjs to angular
janpio Jun 20, 2017
0f5c47d
feature(navigation): better browser back/forward button support
danbucholtz Jun 27, 2017
016b90d
fix(tabs): use segment if it exists even if component exists
danbucholtz Jun 27, 2017
bc7bb21
docs(menu): fix link to menucontroller
mhartington Jun 28, 2017
8dc08f9
fix(select): _inputUpdated should not be called manually
manucorporat Jun 28, 2017
a92d805
chore(changelog): 3.5.0 changelog
danbucholtz Jun 28, 2017
048af1b
chore(changelog): additional nav change details
danbucholtz Jun 28, 2017
5771543
chore(dependencies): update app-scripts to 1.3.11, add npm 5 support
danbucholtz Jun 28, 2017
a7e5fa7
chore(dependencies): lock file updated
danbucholtz Jun 28, 2017
486bff0
feat(navigation): support for named ion-nav/ion-tabs to improve url i…
danbucholtz Jun 29, 2017
48b3243
fix(navigation): mark as not transitioning on success in addition to …
danbucholtz Jun 29, 2017
04e78d8
fix(navigation): fix swipe-to-go-back
danbucholtz Jun 30, 2017
fce4422
fix(navigation): navs can have n child navs instead of just one
danbucholtz Jun 30, 2017
3f39e14
fix(tabs): have tabs behavior match nav when navigating back/forth vi…
danbucholtz Jul 3, 2017
eb830d4
chore(app): fix linting issues
danbucholtz Jul 3, 2017
efd5475
chore(lint): fix all code that doesn't pass tslint
danbucholtz Jul 5, 2017
d22d77b
fix(navigation): restore getActiveChildNav method to maintain old API…
danbucholtz Jul 6, 2017
5a4b351
chore(build): remove linting checks we do not want for dist
jgw96 Jul 6, 2017
e079f77
chore(build): use cross-spawn instead of spawn
jgw96 Jul 6, 2017
923e3b2
chore(build): import spawnSync from correct package
jgw96 Jul 6, 2017
3e3a00b
chore(lockfile): idk why this thing keeps updating
danbucholtz Jul 6, 2017
b5aa304
fix(sliding-item): ionSwipe event is fired (#12157)
manucorporat Jul 10, 2017
693c1c5
docs(content): type Sroll => Scroll (#12281)
janpio Jul 10, 2017
ad25cd1
fix(select): not activated on enter in input field
manucorporat Jul 10, 2017
08be9dc
fix(navigation): ts2.4 compatibility
RoopeHakulinen Jul 10, 2017
9ffc52b
chore(dependencies): recreate lockfile with npm 5.1
danbucholtz Jul 12, 2017
347c260
docs(events): fix syntax error (#12317)
pranjal-goswami Jul 13, 2017
6d8da0a
chore(generator): remove ionicPage for now (#12347)
mhartington Jul 13, 2017
2153940
chore(changelog): update to 3.5.1
danbucholtz Jul 13, 2017
acb6fac
chore(changelog): 3.5.2 release
danbucholtz Jul 13, 2017
889b49f
chore(changelog): 3.5.2 upgrade instructions
danbucholtz Jul 13, 2017
4c13535
chore(changelog): additional details about upgrading and updating app…
danbucholtz Jul 13, 2017
d23b9f7
docs(toast): add import statement in usage (#12278)
b264 Jul 13, 2017
f7fce5f
chore(changelog): update changelog to save app-scripts as devDependency
peterpeterparker Jul 14, 2017
ce46c24
chore(changelog): 3.5.2 changelog
danbucholtz Jul 13, 2017
2d49e10
fix(app): restore getActiveNav api
danbucholtz Jul 14, 2017
ab511c4
chore(dependencies): add angular/tsc-wrapper to package.json to avoid…
danbucholtz Jul 14, 2017
cec718c
chore(dependencies): removing tsc-wrapped since angular explicitely s…
danbucholtz Jul 14, 2017
c4e7552
chore(dependencies): update the lock file
danbucholtz Jul 14, 2017
5b9fe5e
chore(changelog): 3.5.3 release
danbucholtz Jul 14, 2017
961bfc3
chore(docs): add anchor links to documentation sub-sections (#12386)
samuelgoodell Jul 18, 2017
97f9522
fix(list): remove margin of MD buttons in ion-item-options (#12263)
Jul 21, 2017
a8ceee4
fix(navigation): reduce urls to minimum set of fields
danbucholtz Jul 22, 2017
519d657
chore(karma): fix duplicate console.log issue
danbucholtz Jul 24, 2017
add0c4e
fix(navigation): fix bug where that occurred when tab identifier and …
danbucholtz Jul 24, 2017
400aa54
feat(generators): refactor generators
mhartington Jul 25, 2017
4596dbe
fix(navigation): account for race conditions in developer's code
danbucholtz Jul 25, 2017
de0f9d5
fix(nav): make call to setPages return the promise so if it rejects i…
danbucholtz Jul 26, 2017
584afd0
fix(navigation): fix null pointer exceptions that would occur when de…
danbucholtz Jul 26, 2017
16f2ebe
chore(changelog): 3.6.0 changelog
danbucholtz Jul 27, 2017
e401997
chore(changelog): change --save to --save-dev for app-scripts
danbucholtz Jul 27, 2017
f605f0a
chore(changelog): add details about tabUrlPath to changelog
danbucholtz Jul 27, 2017
1b06dd4
fix(infinite-scroll): properly updates scrollTop of ion-content
stalniy Aug 7, 2017
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

For Ionic V1 issues - http://plnkr.co/edit/Xo1QyAUx35ny1Xf9ODHx?p=preview

For Ionic issues - http://plnkr.co/edit/z0DzVL?p=preview
For Ionic issues - http://plnkr.co/edit/cpeRJs?p=preview
-->

**Related code:**
Expand Down
272 changes: 272 additions & 0 deletions CHANGELOG.md

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions demos/src/alert/pages/page-one/page-one.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,13 @@ export class PageOne {
buttons: [
{
text: 'Cancel',
handler: (data) => {
handler: () => {
console.log('Cancel clicked');
}
},
{
text: 'Save',
handler: (data) => {
handler: () => {
console.log('Saved clicked');
}
}
Expand Down
2 changes: 1 addition & 1 deletion demos/src/events/app/app.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export class AppComponent {
this.listenToLoginEvents();
}

openPage(menu: any, page: any) {
openPage(_: any, page: any) {
// find the nav component and set what the root page should be
// reset the nav to remove previous pages and only have this page
// we wouldn't want the back button to show in this scenario
Expand Down
2 changes: 1 addition & 1 deletion demos/src/item-sliding/pages/page-one/page-one.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export class PageOne {
this.expandAction(item, 'downloading', 'Login was downloaded.');
}

expandAction(item: ItemSliding, action: string, text: string) {
expandAction(item: ItemSliding, _: any, text: string) {
// TODO item.setElementClass(action, true);

setTimeout(() => {
Expand Down
14 changes: 14 additions & 0 deletions demos/src/select/pages/page-one/page-one.html
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@
</ion-select>
</ion-item>

<ion-item>
<ion-label>Hair Color</ion-label>
<ion-select [(ngModel)]="hairColor" okText="Okay" cancelText="Dismiss" [compareWith]="compareFn">
<ion-option *ngFor="let o of hairColorData" [value]="o">{{o.text}}</ion-option>
</ion-select>
</ion-item>

<ion-item>
<ion-label>Gaming</ion-label>
<ion-select [(ngModel)]="gaming" okText="Okay" cancelText="Dismiss">
Expand Down Expand Up @@ -147,6 +154,13 @@
</ion-select>
</ion-item>

<ion-item>
<ion-label>Skittles</ion-label>
<ion-select [(ngModel)]="skittles" multiple="true" okText="Okay" cancelText="Dismiss" [compareWith]="compareFn">
<ion-option *ngFor="let o of skittlesData" [value]="o">{{o.text}}</ion-option>
</ion-select>
</ion-item>

<ion-item>
<ion-label>Disabled</ion-label>
<ion-select multiple disabled="true">
Expand Down
32 changes: 32 additions & 0 deletions demos/src/select/pages/page-one/page-one.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ export class PageOne {
petAlertOpts: any;
petData: any;
pets: Array<string>;
hairColorData: any;
hairColor: any;
skittlesData: any;
skittles: Array<any>;
notifications: string = 'mute_1';
rating: number = 2;

Expand All @@ -31,9 +35,37 @@ export class PageOne {
{ text: 'Honey Badger', value: 'honeybadger' },
];

this.hairColorData = [
{ text: 'Brown', value: 'brown' },
{ text: 'Blonde', value: 'blonde' },
{ text: 'Black', value: 'black' },
{ text: 'Red', value: 'red' }
];

// Pre-selected object with different object reference
this.hairColor = { text: 'Brown', value: 'brown' };

this.skittlesData = [
{ text: 'Red', value: 'red' },
{ text: 'Orange', value: 'orange' },
{ text: 'Yellow', value: 'yellow' },
{ text: 'Green', value: 'green' },
{ text: 'Purple', value: 'purple' }
];

// Pre-selected object with different object reference
this.skittles = [
{ text: 'Red', value: 'red' },
{ text: 'Purple', value: 'purple' }
];

this.pets = ['cat', 'dog'];
}

compareFn(option1: any, option2: any) {
return option1.value === option2.value;
}

monthChange(val: any) {
console.log('Month Change:', val);
}
Expand Down
Loading