Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sliding-item): ionSwipe event is fired #12157

Merged
merged 1 commit into from
Jul 10, 2017

Conversation

manucorporat
Copy link
Contributor

fixes #12146

@manucorporat manucorporat merged commit b5aa304 into ionic-team:master Jul 10, 2017
@codebeauty
Copy link

Cool, any idea of time for the next tagged release?

Keep it up 👍

@codebeauty
Copy link

@PatrickMcD What have I missed, why thumbs down? It is just a important question for me.

@WhatsThatItsPat
Copy link

WhatsThatItsPat commented Jul 10, 2017

@codebeauty Your comment is inconsiderate spam to this repo's ~2000 watchers. It adds nothing to the conversation. It is just another "plus one / are we there yet" comment which only serves to fill our inboxes.

We all have "important questions" and features we want implemented. If each of us made similar comments, this forum would be useless and our inboxes would be full.

Additionally, and ironically, comments like yours slow down development. The time the Ionic team wastes reading and responding, is time they could spend writing code.

Exercising patience, rather than nagging the Ionic team, will speed up delivery of new features and is more considerate to watchers.


Thanks for taking the time to understand and for considering everyone else in the future. And I hope you notice this update to my comment.

As for using the negative emoji, there really isn't another choice. Were I to comment on every spammish comment, I'd be participating in the same spam I'm trying to prevent while doubling unwanted messages to other watchers. Because of this, I use the downvote and hope that most will understand.

I respond with comments sparingly or when called out. It's also why I edit comments with new information (like I'm doing now) so watchers don't get another message in their inbox.

@codebeauty
Copy link

@PatrickMcD nagging the team or spam is not my intention. Bugfixes of common features like this one are really important. I unfortunately forgot the watchers, sorry for that. Will not happen again.

But just placing a negative emoji not really helps the communication in any way. Sorry for circumstances and I'll wait.

Thanks, and again keep up the good work.
Bye
Mathias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ionSwipe event not being called when ion-item-options has content
3 participants