-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(item-reorder): add side support #11642
Merged
Merged
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
37a9489
feat(item-reorder): add side
AmitMY 44f8d0f
feat(item-reorder): host the side
AmitMY f7dc4e8
tests(item-reorder): add tests for all sides
AmitMY ce128c1
feat(item-reorder): add classes
AmitMY 93279f0
fix(item-reorder): change coord depending on side
AmitMY 56c7e02
feat(item-reorder): add ltr support
AmitMY 26e2699
style(item-reorder): fix indent
AmitMY a6ca1a6
feat(item-reorder): support only start and end
AmitMY b64be3d
Merge remote-tracking branch 'remotes/upstream/master' into item-reorder
AmitMY f78f096
fix(item-reorder): correct test
AmitMY a30f433
refactor(item-reorder): boolean comparison, css variable
AmitMY 6ea2fb6
fix(item-reorder): test need to use item group
AmitMY 02c09dd
Merge remote-tracking branch 'upstream/master' into item-reorder
AmitMY 59c7d97
fix(item-reorder): remove deprecated icon/item
AmitMY File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -142,6 +142,7 @@ export class ReorderIndexes { | |
host: { | ||
'[class.reorder-enabled]': '_enableReorder', | ||
'[class.reorder-visible]': '_visibleReorder', | ||
'[class.reorder-side-start]': 'side === "start"' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Change string comparison to boolean |
||
} | ||
}) | ||
export class ItemReorder implements ItemReorderGestureDelegate { | ||
|
@@ -158,6 +159,11 @@ export class ItemReorder implements ItemReorderGestureDelegate { | |
*/ | ||
@Output() ionItemReorder: EventEmitter<ReorderIndexes> = new EventEmitter<ReorderIndexes>(); | ||
|
||
/** | ||
* @input {string} Which side of the view the ion-reorder should be placed. Default `"end"`. | ||
*/ | ||
@Input() side: 'start' | 'end' = 'end'; | ||
|
||
constructor( | ||
private _plt: Platform, | ||
private _dom: DomController, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in other to prevent DRY, could we use a scss variable like $reorder-initial-transform ?