Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rtl): add rtl margin, padding, position and border-radius #11342

Merged
merged 58 commits into from
May 12, 2017
Merged
Changes from 1 commit
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
cb5ac7c
refactor(item): replaced item-left with item-start
AmitMY Apr 7, 2017
4509c1f
style(item): fix spacing
AmitMY Apr 8, 2017
2172d11
fix(item): add backwards support for left/right in ng-content
AmitMY Apr 24, 2017
22d24a0
fix(item): deprecated old variables, not breaking change
AmitMY Apr 24, 2017
e1da67d
Merge remote-tracking branch 'origin/breaking-item' into breaking-item
AmitMY Apr 24, 2017
d103932
Merge branch 'master' into breaking-item
AmitMY Apr 24, 2017
13294ed
feat(rtl): padding mixin
AmitMY Apr 24, 2017
5ab8d60
feat(rtl): change all padding variables to start/end
AmitMY Apr 24, 2017
2b3897a
feat(rtl): replace all padding-side with start/end
AmitMY Apr 24, 2017
abdff51
Merge remote-tracking branch 'origin/start-end' into start-end
AmitMY Apr 24, 2017
6629092
revert(functions): remove mixins
AmitMY Apr 24, 2017
ce2d9f1
feat(scss): add padding-horizontal and rtl functions (thanks brandy)
AmitMY Apr 24, 2017
a6c1feb
feat(padding): use padding horizontal mixin everywhere
AmitMY Apr 24, 2017
1a4e0d4
feat(padding): use padding horizontal mixin everywhere
AmitMY Apr 24, 2017
a332df7
fix(lint): change properties order. tests passing
AmitMY Apr 24, 2017
bfe80bb
fix(sass-functions): reorder functions to avoid warning
AmitMY Apr 24, 2017
bdafbf8
fix(scss): fix variable name
AmitMY Apr 24, 2017
762fdb0
perf(rtl): add check if need rtl selector
AmitMY Apr 25, 2017
8f228e8
feat(scss): add full padding function
AmitMY Apr 25, 2017
4f81dd2
feat(scss): add border-radius mixin
AmitMY Apr 25, 2017
f2077f4
fix(rtl): change border-radius to use mixin
AmitMY Apr 25, 2017
d27b7b0
perf(scss): only override if has something to override
AmitMY Apr 25, 2017
8ebd500
feat(scss): add margin scss variables for sides
AmitMY Apr 25, 2017
40624db
feat(scss): add margin mixin
AmitMY Apr 25, 2017
bc93198
fix(scss): fix wrong support for 2/3 args
AmitMY Apr 25, 2017
c79db3b
feat(rtl): spread margins/paddings
AmitMY Apr 25, 2017
788728a
feat(rtl): spread margins/paddings
AmitMY Apr 25, 2017
ffce076
feat(position): add rtl support for absolute
AmitMY Apr 25, 2017
2c89379
fix(rtl): add missing calls
AmitMY Apr 26, 2017
0d4e5c1
fix(item): old attributes deprecated support
AmitMY Apr 27, 2017
df3f74e
revert(changelog): not intended to be changed
AmitMY Apr 27, 2017
e428c61
Merge branch 'master' into start-end
AmitMY Apr 27, 2017
cfecb3e
Merge branch 'master' into start-end
AmitMY May 1, 2017
2b409e1
fix(sass-functions): and not &&
AmitMY May 2, 2017
00152e9
fix(padding): merge + missing padding
AmitMY May 2, 2017
93f78c2
fix(padding): merge + missing padding
AmitMY May 2, 2017
6f84b7b
style(): remove newline
AmitMY May 2, 2017
b8721c8
refactor(mixins): move mixins to mixins file
AmitMY May 2, 2017
cf99437
style(): fix alignment
AmitMY May 2, 2017
d1ac9a0
fix(item): right padding should not be set
AmitMY May 2, 2017
3cbc8d6
fix(): incorrect defaults
AmitMY May 2, 2017
3577190
feat(scss-lint): disable some side variables
AmitMY May 4, 2017
7e38881
fix(scss): lint passes
AmitMY May 4, 2017
1a863ef
feat(lint): disabled text-align
AmitMY May 4, 2017
7307706
fix(): correct variable name
AmitMY May 4, 2017
b6ad052
fix(fab): missed a comma
AmitMY May 4, 2017
4376436
Merge branch 'master' into start-end
AmitMY May 4, 2017
d1ce2d6
fix(rtl): rtl method incorrect for multiple selectors
AmitMY May 5, 2017
8d045b7
fix(rtl): toolbar bad merge
AmitMY May 5, 2017
c25eca6
fix(rtl): icon-only is in px not em
AmitMY May 5, 2017
3757a44
fix(rtl): toggle padding
AmitMY May 5, 2017
5ad8328
feat(rtl): correct notation for rtl custom
AmitMY May 5, 2017
02b6df9
Merge branch 'master' into breaking-item
AmitMY May 5, 2017
7dcdac6
Merge branch 'master' into start-end
AmitMY May 5, 2017
55ac2c5
Merge branch 'breaking-item' into start-end
AmitMY May 5, 2017
94cf77e
Merge branch 'breaking-item' into start-end
AmitMY May 5, 2017
2857678
Merge branch 'master' into start-end
AmitMY May 5, 2017
176b454
fix(scss): fix for deprecated usages
AmitMY May 8, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(rtl): rtl method incorrect for multiple selectors
AmitMY committed May 5, 2017

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit d1ce2d6a9aba86e9d34b2001bac50b9a6d9b4cc4
2 changes: 1 addition & 1 deletion src/components/item/item.wp.scss
Original file line number Diff line number Diff line change
@@ -182,7 +182,7 @@ $item-wp-sliding-content-background: $list-wp-background-color !default;

.item-wp ion-avatar[item-right],
.item-wp ion-thumbnail[item-right] {
@include margin(($item-wp-padding-end / 2));
@include margin($item-wp-padding-end / 2);
}


7 changes: 5 additions & 2 deletions src/themes/ionic.mixins.scss
Original file line number Diff line number Diff line change
@@ -161,8 +161,11 @@ $include-rtl: true !default;

@mixin rtl() {
@if $include-rtl {
@at-root [dir="rtl"] #{&} {
@content;
$root: #{&};
@at-root [dir="rtl"] {
#{$root} {
@content;
}
}
}
}