Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : "ion-slides" - fast rerendering causes a crash #11100

Merged
merged 3 commits into from
Apr 24, 2017

Conversation

mickadoua
Copy link
Contributor

add condition, to check if slider exist before remove

Short description of what this resolves:

bug on fast rerendering #10830

Changes proposed in this pull request:

  • check if slider exist before clean

Ionic Version: 2.2.1

Fixes: #10830

add condition, to check if slider exist before remove
@mickadoua mickadoua changed the title fix #10830 fix : "ion-slides" - fast rerendering causes a crash Apr 6, 2017
@mickadoua
Copy link
Contributor Author

any update ?

@manucorporat manucorporat merged commit 78d427d into ionic-team:master Apr 24, 2017
@Creawebs
Copy link

Fixes: #10830
Is lacking on
function destroyLoop(s) {

eachChild(s._wrapper, '.' + CLS.slide + '.' + CLS.slideDuplicate, function (ele) {
    ele.parentElement.removeChild(ele);
});
for (var /** @type {?} */ i = 0; i < s._slides.length; i++) {
    s._slides[i].removeAttribute('data-swiper-slide-index');
}

}

It shows the same error when calling s._slides.length, same fix might apply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants