Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): don't allow focus when disabled is set #10214

Merged
merged 1 commit into from
Jan 27, 2017
Merged

Conversation

brandyscarney
Copy link
Member

Adds the disabled attribute to the parent input/textarea, also fixes
where disabled textareas were focusable regardless of where disabled
was set.

Testing this:

fixes #10155

Adds the disabled attribute to the parent input/textarea, also fixes
where disabled textareas were focusable regardless of where disabled
was set

fixes #10155
@brandyscarney brandyscarney requested a review from jgw96 January 27, 2017 19:53
@brandyscarney brandyscarney added this to the 2.0.1 milestone Jan 27, 2017
@brandyscarney
Copy link
Member Author

This also fixes where item wasn't getting .item-input-disabled like it should.

Copy link
Contributor

@jgw96 jgw96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on both Android and iOS

@jgw96 jgw96 merged commit eba0866 into master Jan 27, 2017
@jgw96 jgw96 deleted the fix-input-disabled branch January 27, 2017 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disabled inputs with a formControlName are still focusable
2 participants