-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List items "clicking" when scrolling (1.0 Beta) #997
Comments
Related: #970 |
@adamdbradley possibly related too. http://forum.ionicframework.com/t/facing-problem-on-scrolling/2399/4 Seems there are issues with text input as users try to scroll. I tried wrapping the inputs with a specific label (not the best of practice but can work in some cases) but still not luck.
|
I'm currently working on a few solutions and hopefully have something posted soon, thanks. |
Could this be related to the issue where form fields steal focus when Related: #931 |
I haven't played with it much but it could be @rvanbaalen. There's been some post on the forum that have been reporting the clicking issue and fields stealing focus. Maybe something to do with #791? |
I just committed a change where it's no longer testing against the f3bd258#diff-f2135b81b6b1a2b40fa3998c02a80a4fL135 I've tested my fixes on iOS7, desktop chrome (both mouse and with touch events enabled), Android 4.2, and Android 2.3, but I haven't closed this issue yet. Would I be able to get some additional help testing? Thanks. http://code.ionicframework.com/#nightly (build 1512 or later) |
I'll update and test it on iOS7.1 now. This should fix the issue I addressed in my previous comment regarding the input fields stealing focus when trying to scroll? From the looks of your comment (regarding the 'mousedown' event) it seems like this is the case. |
I can confirm the scrolling is fixed for me on iOS 7.1. Although on my login screen I kept trying to click on password and it would focus but then immediately lose focus. After a while of clicking it and messing around I finally got it to keep focus so I could enter my password. |
Everything looks good with list items, but text inputs are still a bit problematic. |
Yeah the input fields issue is still ongoing. |
OK, will probably just revert the change then. Let's open a new issue #1012 |
Ok I made another change to not ignore a scroll touchstart if the targe was an input (build 1517 or later) |
@adamdbradley I think things are good. I tested on the codepen I posted earlier and it seems to work. I'll try on an actual device in the morning. |
… ignored, #997 Previously I disabled the activation class immediately on a touchmove, where as the click will still work if you touchstart and touchend within a few pixels of each other. So visually it may have looked like the click shouldn't have worked. I just updated it so the use the same numbers. For example, if you hold down an item and move just 5 pixels, the item will stay active (before it wouldn't have), and the click will fire. But at the same time, if you hold down an item, and move a larger distance, once it realizes that it went farther than 6 pixels it'll not allow a click to happen, AND it'll not show the item as being active.
I have unwanted clicks while scrolling a list. Sorry for the newbie question, but how can I update my current ionic project to test this fix? Nevermind! Got it. Just dowloaded the newest files from http://code.ionicframework.com/#nightly and replaced them in my project. My problem seems to be fixed. Thanks! |
All good! Please consider asking in the forum first before opening up an issue on Github. :) |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
When trying to scroll a list of items, I am often frequently taken into a list item's detail view because the "click" event accidently fired when scrolling. This makes scrolling pretty annoying since I am often just randomly taken into items. I don't remember noticing this before 1.0 Beta but could be wrong.
Also reported by others:
http://forum.ionicframework.com/t/enters-list-items-when-try-to-scroll-through-list/2309
http://forum.ionicframework.com/t/how-to-scroll-without-accidently-clicking-list-items/2466/5
The text was updated successfully, but these errors were encountered: