Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WKWebView swipe back sometimes freezes application #9367

Closed
biesbjerg opened this issue Nov 26, 2016 · 8 comments
Closed

WKWebView swipe back sometimes freezes application #9367

biesbjerg opened this issue Nov 26, 2016 · 8 comments
Assignees
Milestone

Comments

@biesbjerg
Copy link

Ionic version: (check one with "x")
[ ] 1.x
[x] 2.x

I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:
Using WKWebView, when swiping to go back, sometimes the app stops responding to further interaction. No errors are thrown in Xcode console. Sometimes it happens after trying swiping back 3 times, other times it happens after 50 tries - haven't been able to reproduce it reliably.

Steps to reproduce:

  1. Tap an item in a list
  2. Swipe to go back
  3. Repeat until app stops responding

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):

Cordova CLI: 6.4.0
Ionic CLI Version: 2.1.13
Ionic App Lib Version: 2.1.7
ios-deploy version: 1.9.0
ios-sim version: 5.0.11
OS: macOS Sierra
Node Version: v6.9.1
Xcode version: Xcode 8.1 Build version 8B62
@manucorporat manucorporat added this to the 2.0.0-rc.4 milestone Nov 26, 2016
@manucorporat manucorporat self-assigned this Nov 26, 2016
@biesbjerg
Copy link
Author

When inspecting the connected device, when the app is in this "crashed state", I see ion-app has the class disable-scroll. If I remove this class, the app starts responding again.

Seems like somehow it is not detecting when swipe has ended?

image

@biesbjerg
Copy link
Author

Xcode log, leading up to a non-responding app:

2016-11-26 18:42:58.903143 Mindly[5849:1452733] App Root: Scroll Disable Assist true
2016-11-26 18:42:58.903436 Mindly[5849:1452733] CDVWKWebViewEngine: handleStopScroll
2016-11-26 18:42:59.068220 Mindly[5849:1452733] App Root: Scroll Disable Assist false
2016-11-26 18:43:02.108085 Mindly[5849:1452733] App Root: Scroll Disable Assist true
2016-11-26 18:43:02.108876 Mindly[5849:1452733] CDVWKWebViewEngine: handleStopScroll
2016-11-26 18:43:02.214207 Mindly[5849:1452733] App Root: Scroll Disable Assist false
2016-11-26 18:43:02.952600 Mindly[5849:1452733] App Root: Scroll Disable Assist true
2016-11-26 18:43:02.960048 Mindly[5849:1452733] CDVWKWebViewEngine: handleStopScroll
2016-11-26 18:43:03.106176 Mindly[5849:1452733] App Root: Scroll Disable Assist false
2016-11-26 18:43:06.153508 Mindly[5849:1452733] App Root: Scroll Disable Assist true
2016-11-26 18:43:06.154071 Mindly[5849:1452733] CDVWKWebViewEngine: handleStopScroll
2016-11-26 18:43:06.253049 Mindly[5849:1452733] App Root: Scroll Disable Assist false
2016-11-26 18:43:09.897074 Mindly[5849:1452733] App Root: Scroll Disable Assist true
2016-11-26 18:43:09.897256 Mindly[5849:1452733] CDVWKWebViewEngine: handleStopScroll
2016-11-26 18:43:09.956330 Mindly[5849:1452733] App Root: Scroll Disable Assist false

@manucorporat
Copy link
Contributor

@biesbjerg thanks very much for your debugging effort! I might know what is going on!

@biesbjerg
Copy link
Author

Hmm, I managed to crash it, and when inspecting the html the disable-scroll was not present, so not really sure what's going on.

@manucorporat
Copy link
Contributor

@biesbjerg I just pushed a possible fix to this issue, but I will leave this open until verification

@manucorporat
Copy link
Contributor

manucorporat commented Nov 26, 2016

Framework side: 177a089
Plugin side: ionic-team/cordova-plugin-wkwebview-engine@4276f7e

@biesbjerg
Copy link
Author

So far so good, @manucorporat!

It seems to be working now.
Thank you for fixing this so fast!

@manucorporat
Copy link
Contributor

manucorporat commented Nov 26, 2016

@biesbjerg awesome! I released a new nightly version, in case you want to test easily in one of your apps.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants