Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(statusbarPadding): add variables to differentiate status bar height between modes #8712

Closed
brandyscarney opened this issue Oct 14, 2016 · 0 comments · Fixed by #8788
Closed

fix(statusbarPadding): add variables to differentiate status bar height between modes #8712

brandyscarney opened this issue Oct 14, 2016 · 0 comments · Fixed by #8788
Assignees
@brandyscarney
Milestone
2.0.0-rc.2

Comments

@brandyscarney
Copy link
Member

With the previous theming we could share one variable and change it per mode:

$cordova-ios-statusbar-padding:           31px;

But now that all of the modes are combined we need to be able to change this per mode - I think changing the variable name to use the mode should do it.
@brandyscarney brandyscarney added this to the 2.0.0-rc.2 milestone Oct 14, 2016
@brandyscarney brandyscarney self-assigned this Oct 14, 2016
brandyscarney added a commit to ionic-team/ionic-preview-app that referenced this issue Oct 14, 2016
@brandyscarney
fix(theme): add deleted styles back including status bar
c98db13 
status bar is not perfectly aligned per mode, see issue
ionic-team/ionic-framework#8712 for the reason
@brandyscarney brandyscarney mentioned this issue Oct 18, 2016
Closed
brandyscarney added a commit that referenced this issue Oct 18, 2016
@brandyscarney
fix(cordova): add Sass variables for md and wp statusbar padding
3844520 
fixes #8712
@brandyscarney brandyscarney mentioned this issue Oct 18, 2016
Merged
manucorporat pushed a commit that referenced this issue Oct 18, 2016
@brandyscarney @manucorporat
fix(cordova): add Sass variables for md and wp statusbar padding (#8788)
8921cb1 
* fix(cordova): add Sass variables for md and wp statusbar padding

fixes #8712

* style(cordova): remove extras spaces
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brandyscarney brandyscarney

Labels
None yet
Projects
None yet
Milestone
2.0.0-rc.2
Development

Successfully merging a pull request may close this issue.

fix(cordova): add Sass variables for md and wp statusbar padding ionic-team/ionic-framework
1 participant
@brandyscarney