Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionic 2 Beta 6, iOS - Side Menu dismiss sometimes requires 2 taps #6405

Closed
anthonytietjen opened this issue May 2, 2016 · 54 comments
Closed
Assignees

Comments

@anthonytietjen
Copy link

Short description of the problem:

Dismissing the side menu in Ionic 2 beta 6 ios app sometimes requires 2 taps.

What behavior are you expecting?

The side menu would be dismissed with just one tap outside of the menu.

Steps to reproduce:

  1. $ ionic start MySideMenu sidemenu --v2 --ts
  2. $ ionic run ios --device
  3. Expand the side menu
  4. Tap on the right side of the screen to dismiss the sidemenu.
  5. The side menu doesn't always collapse with just one tap. Sometimes it requires two taps.

Which Ionic Version? 1.x or 2.x
2 beta 6

Run ionic info from terminal/cmd prompt: (paste output below)
Cordova CLI: Not installed
Gulp version: CLI version 3.9.0
Gulp local: Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.6
Ionic CLI Version: 2.0.0-beta.25
Ionic App Lib Version: 2.0.0-beta.15
ios-deploy version: 1.8.5
ios-sim version: 3.1.1
OS: Mac OS X El Capitan
Node Version: v0.12.7
Xcode version: Xcode 7.3 Build version 7D175

@ghenry22
Copy link

ghenry22 commented May 2, 2016

I have seen the same. This behaviour was also present in beta4&5.

Android and browser platforms seem to work as expected for me only iOS presents this issue.

Opening the menu and selecting items opens and closes fast and correctly, opening the menu and then tapping outside the menu or on the menu button often takes 2 taps to close the side menu.

@boboxiaodd
Copy link

I also found this issue, and when side menu opened, main page content can scroll up and down, I think this is not a good experience

@ghenry22
Copy link

This issue still exists in Beta9. No issue on Android or browser but on iOS clicking the hamburger opens the menu without issue but clicking/tapping to close the menu almost always takes 2 taps. This is a small bug that makes a majorly bad user impression, would be good if it could get assigned to a milestone.

@ghenry22
Copy link

ghenry22 commented Jul 4, 2016

This still exists in beta10.
Only seems to be present in ios.
Often takes 2 taps on the hamburger to close the side menu.
@jgw96 - as this is a pretty major bit of functionality for anyone with a side menu on ios perhaps it could be included into beta11 which is focused on bug fixing?

@manucorporat manucorporat self-assigned this Jul 4, 2016
@manucorporat
Copy link
Contributor

I have been debugging this issue, it affects "push" menu, because it does not have backdrop. Working in a fix 👍

@ghenry22
Copy link

awesome that will be really nice to get fixed!

@markanye
Copy link

I'm seeing the same kind of behavior with beta10. I've created a very simple Ionic2 application with a side menu and three pages with static content. Running in the browser or on android, navigation is smooth and very responsive. But on iOS opening and closing the menu or activating menu links often taken more than one click/tap, and transitions are not consistently smooth.

@AcademyLime
Copy link

This bug still exists in beta.11, any updates?

@AcademyLime
Copy link

Weird.. When I swipe open the menu and tap on the content to close it, it works. But when opened with the navbar menu button, requires 2-3 taps or maybe 3 seconds for it to close.

@overgaardmorten
Copy link

overgaardmorten commented Sep 1, 2016

Any updates on this bug ?

@AbrahamLopez10
Copy link

AbrahamLopez10 commented Sep 6, 2016

This is also reported on issue #6645 but that issue was "closed" just like this one, even though it is not yet fixed. Why would that happen?

Ionic team, we beg for your attention on this critical bug! We cannot ship our app yet because the side menu is so buggy! D:

@AbrahamLopez10
Copy link

Anybody here? Please, why there's no feedback regarding this bug which has been reported in 4 different issues (AFAIK)? Please, please, please... the sidemenu needs to fully work and be bug free for beta 12!

@RigoOnRails
Copy link

Also happening to me. I need this fixed quickly.

@markanye
Copy link

Still a roadblock for me as well. A fix would be much appreciated!

@jgw96
Copy link
Contributor

jgw96 commented Sep 13, 2016

Hello all! Sorry for the delay on this. This should be fixed in beta.12 and when i have tested this I will post my findings here. Thanks for using Ionic!

@AbrahamLopez10
Copy link

Thanks Justin, your response on this matter is much appreciated. Any target release date for beta 12 and RC1? We're anxious to ship our app with Ionic v2! :D

@jgw96
Copy link
Contributor

jgw96 commented Sep 15, 2016

No target release date at the moment besides ASAP 😄 We are very hard at work on beta.12. There were a ton of changes in Angular 2 starting with RC5 and we are also building a completely new build process that will include AOT compile, treeshaking, minification and more that will help enormously with start up time and navigation performance. Thanks!

@ghenry22
Copy link

still present in RC0. start a new project with side menu template. run in emulator and open and close the side menu. closing requires multiple clicks.

At an RC stage for ionic2 being able to close a side menu on ios really seems like something that should be working...

@AbrahamLopez10
Copy link

Come on guys you told us this was going to be fixed on this release, and
you closed all the issues (literally) in which this bug was reported.

Several of us haven't been able to launch their Ionic 2 app due to this
bug, which has been reported in several (now closed) issues since beta 7
with no satisfactory reply or solution from the team.

We really want to make Ionic as our de facto mobile development platform,
but we cannot feel confident in the framework of services if simple matters
like fixing a critical bug that was reported months ago by multiple people
cannot be fixed after all this time and promises.

Some one from Ionic please please please jump in and let us know if this
will be fixed ASAP! :( or give us a hot fix we can temporarily patch Ionic
with.

On Wednesday, September 28, 2016, Gaven Henry [email protected]
wrote:

still present in RC0. start a new project with side menu template. run in
emulator and open and close the side menu. closing requires multiple clicks.

At an RC stage for ionic2 being able to close a side menu on ios really
seems like something that should be working...


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#6405 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKDHSBLXFySi1PxF6v__we_8xqhNC_uAks5quymUgaJpZM4IVhlq
.

Sent from my iPhone

@manucorporat
Copy link
Contributor

manucorporat commented Sep 29, 2016

@aplimovil @ghenry22 I started working in a fix some weeks ago, but I could not finish it because of other issues with higher priority.

Working in a fix today, seriously! ;)

@AbrahamLopez10
Copy link

Thanks a lot for jumping in Manu! Even if it's just a patch to be manually applied the fix would mean a lot for us! It's the only thing standing between us and launching the app we've been developing for months.

Thanks again, looking forward to your reply.

@ghenry22
Copy link

@manucorporat sounds great thanks :)

@markanye
Copy link

markanye commented Oct 19, 2016

@manucorporat @jgw96 I've just updated my app to RC1. The menu toggle button now works consistently pretty well on iOS, but there are still issues with selecting menu items. Usually, it takes more than one tap on a menu item to get it to activate.

@manucorporat
Copy link
Contributor

@mostlymark this PR will improve the responsiveness across the whole framework. #8807

@ghenry22
Copy link

@manucorporat nice one! Can't wait to see how that works!

@mangabr
Copy link

mangabr commented Nov 7, 2016

Hi, i updated my app to RC2 and the problem continues.
Same error: in IOS is necessary two taps in menu item to work. In Android its ok.

@mangabr
Copy link

mangabr commented Nov 7, 2016

The error occur only in IOS when is used top menu button to open side menu.
If use the fingers to push the menu him work fine.

@jfont555
Copy link

jfont555 commented Nov 14, 2016

@manucorporat @mangabr same result here, one tap: menu open & close automatically, with two taps works great.

@ghenry22
Copy link

I can no longer reproduce this bug in my app with rc2. Open and close work exactly as expected now for me

@lnu
Copy link

lnu commented Nov 16, 2016

Even with the rc2 it still happens here. Opening the side menu by sliding works but if you open it by clicking a button you have to tap twice for the click event to be fired.

@chris08002
Copy link

chris08002 commented Feb 20, 2017

I have the same issue with the Ionic2 Final. Not only on the side menu, but also on cards and the back button. Always after a screen transition taps / clicks are not recognised for a second or so. Has anybody found a solution? I have tried tappable and I tried tap and click (which both do not fire).

<ion-card tappable class="module-card" *ngFor="let module of modules"  [navPush]="modulePage" [navParams]="{id: module.id}" (tap)="tapEvent($event)" (click)="clickEvent($event)">
  <img src="{{module.thumbnail}}"/>
  <div class="card-content">
    <div class="card-title">
      <strong>Module {{module.number}}</strong>
    </div>
    <div class="card-subtitle">
      <strong *ngIf="translate.currentLang!='fr'">{{module.subtitle_en}}</strong>
      <strong *ngIf="translate.currentLang=='fr'">{{module.subtitle_fr}}</strong>
    </div>
  </div>
</ion-card>

@bflopez
Copy link

bflopez commented Mar 3, 2017

@chris08002 I am experiencing the same issue. It looks like it doesn't recognize a tap to dismiss the menu within the first second or so.

@chris08002
Copy link

chris08002 commented Mar 4, 2017

@bflopez I just made a test with a fresh "ionic start test sidemenu --v2" and I am having the exact same issue when doing ionic run ios --device. Anybody from the ionic team can confirm this? Is there anything that can be done? (swiping the menu works, it's tap to close that doesn't work)

@ghost
Copy link

ghost commented Mar 6, 2017

I have the same issue on iOS. Menu need at least two or three taps on content section to close!

@AbrahamLopez10
Copy link

I'm now experiencing this as well, using Ionic 2.1.0 and the following ionic info, so it seems to be a regression, as it was fixed in 2.0.0. Please fix!

Cordova CLI: 6.5.0 
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
ios-deploy version: 1.9.0 
ios-sim version: 5.0.13 
OS: OS X Mavericks
Node Version: v6.2.0
Xcode version: Xcode 6.2 Build version 6C131e

@ghost
Copy link

ghost commented Mar 6, 2017

Changing the type to "overlay" has fixed this for me. Not ideal though!

@AbrahamLopez10
Copy link

Ionic team, as a suggestion, it may be worth considering, if it's possible, adding an E2E test for the sidemenu on an iOS simulator or device as part of the internal testing done before each release, just to ensure this nagging issue on sidemenu doesn't happen anymore! :)

@chris08002
Copy link

@Maziar-Fotouhi It doesn't completely fix it for me, but it improves significantly. Thanks.

@mizdler
Copy link

mizdler commented Mar 31, 2017

The issue is still exists on iOS 10.1.1
Cordova CLI: 6.5.0
Ionic Framework Version: 2.3.0
Ionic CLI Version: 2.2.2
Ionic App Lib Version: 2.2.1
Ionic App Scripts Version: 1.1.4
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Linux 4.4
Node Version: v7.4.0
Xcode version: Not installed

@Digiflare-FanL
Copy link

This issue still exists, could we at least re-open it so that it could be tracked.

@chris08002
Copy link

In general I am using material design animations and configuration (like the overlay) for most things now, it seems more stable than iOS configuration in Ionic 2.

@ferminako
Copy link

ferminako commented May 11, 2017

Same problem here, as soon as I click an item in my home page which brings me to other page and go back, the app needs about a second to recognize tap and fire click event. no fixes????

@RealJaJaAdmin
Copy link

@manucorporat , could you please take a look at this? It seems lots of people still have this issue.

@spacedevin
Copy link

i was able to get this fixed by using wkwebview, but its unclear if that is recommended or not.

@ghenry22
Copy link

I also have to use wkwebview to work around this and many other issues that have just not been addressed.

I love ionic but some of these little things need to be fixed so that it works properly in uiwebview as wkwebview has a lot of quirks and issues of its own.

@chris08002
Copy link

@ferminako not a fix bit a workaround: add tappable to all your items that listen on click or tap and use material design transitions.

@ferminako
Copy link

@chris08002 I also tried using tappable
With no success.

@chris08002
Copy link

@ferminako combines with switching animations to material design and the menu to overlay (also from material design)? Only the combination of both did work for me.

@ghost
Copy link

ghost commented May 25, 2017

@ferminako You're facing a different issue.
Please look at these:
#11423
#11110
https://ionicframework.com/docs/troubleshooting/#click-delays

Please make sure you are using <button> in your menu. Also use tappable and use the (tap) event instead of (click) event on those buttons.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 2, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests