-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Problem when changing button's color and style #6202
Comments
Quit your Ionic CLI and run again. Or restart the browser. It must be due to invalid reassignment of values to variables that alter the color of the buttons during Stack refresh. |
If you create a dummy element, say a |
Also, if you attach a class to the button, sometihng like |
@RAMDdFLEET @Frightie Maybe I didn't write a good/clear description - the problem is when both color and style attributes are updated at once. You can observe it in this plunker demo following the repro-steps. Thank you for the suggestions, but I already implemented a fix that should resolve the issue. |
This prevents `button-solid-secondary` from being added when it should just be `button-secondary`. references #6202
updated tests to include toolbar with solid buttons and bar buttons in karma tests. references #6202
Thank you @iignatov for the PR! This will be in the beta.7 release. 😄 |
@brandyscarney Great, thanks for the update! |
Short description of the problem:
When setting the color and style attributes of the button programmatically, the changes are not applied/visualized as expected.
What behavior are you expecting?
The changes to color and style attributes should be visualized as they are set in the code.
Steps to reproduce:
Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)
Which Ionic Version? 2.x
Plunker that shows an example of your issue
http://plnkr.co/edit/2fViim?p=preview
Run
ionic info
from terminal/cmd prompt: (paste output below)The text was updated successfully, but these errors were encountered: