Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tab hidden/shown event #588

Closed
adamdbradley opened this issue Feb 13, 2014 · 2 comments
Closed

Fix tab hidden/shown event #588

adamdbradley opened this issue Feb 13, 2014 · 2 comments
Milestone
0.9.26

Comments

@adamdbradley
Copy link
Contributor

http://forum.ionicframework.com/t/determine-which-tab-is-showing/1050
@adamdbradley adamdbradley added this to the 0.9.26 milestone Feb 13, 2014
ajoslin added a commit that referenced this issue Feb 13, 2014
@ajoslin
fix(tabs): broadcast tab.shown/tab.hidden to only child scopes
69fda4e 
Addresses #588
@ajoslin
Copy link
Contributor

ajoslin commented Feb 13, 2014

Fixed; I started to redo the unit tests but stopped at <tab>, it's really hard to test it right now (tons of dependencies and other things mixing with it).

I did a manual test and it's working as intended.

Waiting for #597 instead.

@ajoslin ajoslin closed this as completed Feb 13, 2014
ajoslin added a commit that referenced this issue Feb 13, 2014
@ajoslin
test(tabs): add tab.shown catching to test page
80ee6c2 
Addresses #588
@jough jough mentioned this issue Mar 4, 2014
Closed
@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.26
Development

No branches or pull requests
2 participants
@adamdbradley @ajoslin