Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tabbarLayout config to tabs #5625

Closed
brandyscarney opened this issue Feb 26, 2016 · 1 comment
Closed

Add tabbarLayout config to tabs #5625

brandyscarney opened this issue Feb 26, 2016 · 1 comment
Assignees
@brandyscarney
Milestone
2.0.0-beta.2

Comments

@brandyscarney
Copy link
Member

Should be able to use tabbarLayout to configure title and icons:

  config: {
    tabbarLayout: 'icon-bottom',
    platforms: {
      android: {
        tabbarLayout: 'icon-hide'
      }
    }
  }

Adam and I came up with the following:

key: tabbarLayout
values: icon-top, icon-left, icon-right, icon-bottom, icon-hide, title-hide

deprecate tabbarIcons
@brandyscarney brandyscarney self-assigned this Feb 26, 2016
@adamdbradley
Copy link
Contributor

👍

@brandyscarney brandyscarney changed the title Add tabbarTitle config to tabs Add tabbarLayout config to tabs Feb 26, 2016
@brandyscarney brandyscarney added this to the 2.0.0-beta.2 milestone Feb 26, 2016
brandyscarney added a commit that referenced this issue Feb 26, 2016
@brandyscarney
refactor(tabs): remove tabbarIcons and add tabbarLayout which accepts…
8cfebe1 
… different values

BREAKING CHANGES: `tabbarIcons` has been replaced with `tabbarLayout`
with the following values: `icon-top`, `icon-left`, `icon-right`,
`icon-bottom`, `icon-hide`, `title-hide`.

closes #5625
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brandyscarney brandyscarney

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta.2
Development

No branches or pull requests
3 participants
@adamdbradley @brandyscarney @Ionitron