Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(ion-item-sliding): Allow item also to swipe from left to right #5073

Closed
mhartington opened this issue Jan 18, 2016 · 12 comments
Closed
Assignees
Milestone

Comments

@mhartington
Copy link
Contributor

From @astec on November 1, 2015 2:46

I want to swipe my ionic list items to both side. (i.e left-right AND right-left). It work perfectly for right-left swipe but i am not able to swipe my list item left-righ (to see buttons on left side).

Here is an example workaround: http://stackoverflow.com/a/31816296/1975086

Copied from original issue: driftyco/ionic2#411

@cagica
Copy link

cagica commented Feb 15, 2016

Do you think I can do a pull request with my answer? People keep asking me for my solution, but the way it was made it won't let people update ionic without loosing the feature.

@masimplo
Copy link
Contributor

+1 for this feature. Both native iOS and android support both sides swiping for items.

@thomastthai
Copy link

Did this code make it into beta? I would love to see this extended to the entire list instead of just the list-items like in Google Now.

manucorporat added a commit to manucorporat/ionic that referenced this issue May 28, 2016
@manucorporat
Copy link
Contributor

@thomastthai @masimakopoulos @pcagica #6686

@thomastthai
Copy link

Thank you for updating. How would I get the change locally before it is
merged into the main branch?
On May 28, 2016 3:24 AM, "Manu Mtz.-Almeida" [email protected]
wrote:

@thomastthai https://github.com/thomastthai @masimakopoulos
https://github.com/masimakopoulos @pcagica https://github.com/pcagica
#6686 #6686


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#5073 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/APxEZV_Gc-s5-67pcygpUYeKCQli45Glks5qGBfNgaJpZM4HHUVA
.

@thomastthai
Copy link

Also, is the code adaptable to being able to swipe the entire list left or
right in addition to the list items?
On May 28, 2016 3:24 AM, "Manu Mtz.-Almeida" [email protected]
wrote:

@thomastthai https://github.com/thomastthai @masimakopoulos
https://github.com/masimakopoulos @pcagica https://github.com/pcagica
#6686 #6686


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#5073 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/APxEZV_Gc-s5-67pcygpUYeKCQli45Glks5qGBfNgaJpZM4HHUVA
.

manucorporat added a commit to manucorporat/ionic that referenced this issue May 31, 2016
manucorporat added a commit to manucorporat/ionic that referenced this issue May 31, 2016
manucorporat added a commit to manucorporat/ionic that referenced this issue May 31, 2016
manucorporat added a commit to manucorporat/ionic that referenced this issue May 31, 2016
manucorporat added a commit to manucorporat/ionic that referenced this issue Jun 1, 2016
@trakhimenok
Copy link

Take into account RTL: #5035 (comment)

manucorporat added a commit to manucorporat/ionic that referenced this issue Jun 4, 2016
manucorporat added a commit to manucorporat/ionic that referenced this issue Jun 4, 2016
manucorporat added a commit to manucorporat/ionic that referenced this issue Jun 4, 2016
manucorporat added a commit to manucorporat/ionic that referenced this issue Jun 4, 2016
@manucorporat
Copy link
Contributor

manucorporat commented Jun 4, 2016

@astec @thomastthai @masimakopoulos the two way sliding will arrive in beta9, it will support having two different sets of buttons at the same time (side left/right), right side will be the default one, so expect it to be back compatible.
It has been improved a lot in general, it will behave more like a native app.
also, you will be able to subscribe to new events like (ionDrag) and (ionSwipe) and implement things like this very easily:

jun-04-2016 18-33-17

The animation below is 100% CSS, so you can customize it.

    <ion-item-sliding #item>
      <ion-item>DOWNLOAD</ion-item>

      <ion-item-options (ionSwipe)="download(item)">
        <button primary (click)="archive(item)">
          <ion-icon name="archive"></ion-icon>Archive
        </button>
        <button secondary swipeable (click)="download(item)">
          <ion-icon name="download"></ion-icon>Download
        </button>
      </ion-item-options>

      <ion-item-options side="left" (ionSwipe)="unread(item)">
        <button secondary swipeable (click)="unread(item)">
          <ion-icon name="ios-checkmark"></ion-icon>Unread
        </button>
      </ion-item-options>

    </ion-item-sliding>

@trakhimenok
Copy link

@manucorporat, that's cool!

manucorporat added a commit to manucorporat/ionic that referenced this issue Jun 4, 2016
@manucorporat manucorporat self-assigned this Jun 6, 2016
manucorporat added a commit to manucorporat/ionic that referenced this issue Jun 6, 2016
@manucorporat
Copy link
Contributor

#6686 was merged, available in next release!

@thomastthai
Copy link

Thank you for the work you did.
On Jun 8, 2016 12:33 PM, "Manu Mtz.-Almeida" [email protected]
wrote:

#6686 #6686 was merged, available
in next release!


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#5073 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/APxEZX4AqU6dtoDEJQFd6hJJkCQYgcXCks5qJxkfgaJpZM4HHUVA
.

@juarezpaf
Copy link

@manucorporat way to go buddy! Keep up the amazing work guys!

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants