Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SlideBox Generates Error Unless active-slide set. #403

Closed
calendee opened this issue Jan 11, 2014 · 6 comments
Closed

SlideBox Generates Error Unless active-slide set. #403

calendee opened this issue Jan 11, 2014 · 6 comments
Assignees

Comments

@calendee
Copy link

FYI : This was also mentioned in the closed issue #360

If you build a slide box but fail to set the active-slide attribute, you'll get this error 👍

Error: [$compile:nonassign] Expression 'undefined' used with directive 'slideBox' is non-assignable!

http://docs.angularjs.org/error/$compile:nonassign?p0=undefined&p1=slideBox

The Angular expiation basically says that if you don't assign something with that directive, it's gotta fail. So, we need the docs to reflect that.

@calendee
Copy link
Author

You must set active-slide to a scope parameter. Setting it to 0 does not work.

@mlynch
Copy link
Contributor

mlynch commented Jan 12, 2014

I think in this case we should change the original code to possibly use
interpolation and just $attr.$observe.

Thoughts?

On Sat, Jan 11, 2014 at 5:43 PM, Justin Noel [email protected]:

FYI : This was also mentioned in the closed issue #360#360

If you build a slide box but fail to set the active-slide attribute,
you'll get this error [image: 👍]

Error: [$compile:nonassign] Expression 'undefined' used with directive
'slideBox' is non-assignable!

http://docs.angularjs.org/error/$compile:nonassign?p0=undefined&p1=slideBox

The Angular expiation basically says that if you don't assign something
with that directive, it's gotta fail. So, we need the docs to reflect that.


Reply to this email directly or view it on GitHubhttps://github.com//issues/403
.

@ghost ghost assigned mlynch Jan 12, 2014
@matiboy
Copy link

matiboy commented Jan 13, 2014

Referring to angular/angular.js#1435 I believe we just need to make the parameter optional with '=?' (I'll submit a pull request for that)

@mlynch
Copy link
Contributor

mlynch commented Jan 13, 2014

Fixed by #404 thanks @matiboy

@mlynch mlynch closed this as completed Jan 13, 2014
@calendee
Copy link
Author

LOL - Just fixed this myself and came here to comment and submit new pull request to discover already solved. Thanks @matiboy.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants