Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): export missing lifecycle interfaces for standalone package #28346

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Oct 12, 2023

Issue number: N/A

Resolves feedback identified here: https://github.com/ionic-team/ionic-angular-standalone-codemods/pull/13/files/baa37ef1e3e8ba773b693db280542efba815482a#r1356414362


What is the current behavior?

The lifecycle interfaces are not exported from @ionic/angular/standalone.

What is the new behavior?

  • Lifecycle interfaces are exported from @ionic/angular/standalone.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: angular @ionic/angular package label Oct 12, 2023
@sean-perkins sean-perkins added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit dd93e0b Oct 12, 2023
45 checks passed
@sean-perkins sean-perkins deleted the sp/standalone-missing-exports branch October 12, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants