Skip to content

Commit

Permalink
fix(angular): export missing lifecycle interfaces for standalone pack…
Browse files Browse the repository at this point in the history
…age (#28346)

Issue number: N/A

Resolves feedback identified here:
https://github.com/ionic-team/ionic-angular-standalone-codemods/pull/13/files/baa37ef1e3e8ba773b693db280542efba815482a#r1356414362

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

The lifecycle interfaces are not exported from
`@ionic/angular/standalone`.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Lifecycle interfaces are exported from `@ionic/angular/standalone`.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
  • Loading branch information
sean-perkins authored Oct 12, 2023
1 parent 79725d7 commit dd93e0b
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 3 deletions.
1 change: 1 addition & 0 deletions packages/angular/common/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export { Platform } from './providers/platform';
export { bindLifecycleEvents, AngularDelegate } from './providers/angular-delegate';

export type { IonicWindow } from './types/interfaces';
export type { ViewWillEnter, ViewWillLeave, ViewDidEnter, ViewDidLeave } from './types/ionic-lifecycle-hooks';

export { NavParams } from './directives/navigation/nav-params';

Expand Down
7 changes: 4 additions & 3 deletions packages/angular/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,12 @@ export {
AngularDelegate,
NavParams,
IonicRouteStrategy,
ViewWillEnter,
ViewWillLeave,
ViewDidEnter,
ViewDidLeave,
} from '@ionic/angular/common';

// TYPES
export * from './types/ionic-lifecycle-hooks';

// PACKAGE MODULE
export { IonicModule } from './ionic-module';

Expand Down
4 changes: 4 additions & 0 deletions packages/angular/standalone/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ export {
Platform,
NavParams,
IonicRouteStrategy,
ViewWillEnter,
ViewDidEnter,
ViewWillLeave,
ViewDidLeave,
} from '@ionic/angular/common';
export { IonNav } from './navigation/nav';
export {
Expand Down

0 comments on commit dd93e0b

Please sign in to comment.