Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: datetime, go button in number pad doesn't do anything #28325

Closed
3 tasks done
iStaha opened this issue Oct 11, 2023 · 4 comments · Fixed by #28848
Closed
3 tasks done

bug: datetime, go button in number pad doesn't do anything #28325

iStaha opened this issue Oct 11, 2023 · 4 comments · Fixed by #28848
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@iStaha
Copy link

iStaha commented Oct 11, 2023 •
edited
Loading

Prerequisites

Ionic Framework Version

v6.x

Current Behavior

Go button ( -> ) doesn't do anything when you click it.

Go.Button.mp4

Expected Behavior

Go button ( -> ) should close the keyboard / date timepicker dialog. Basically, it should have some funtion.

image

image

Steps to Reproduce

  1. Utilize ion-datetime and generate the APK using Cordova, or alternatively, use emulator.
  2. Select the minute column to open the numeric keyboard on your mobile device.
  3. Attempt to use the "Go" button or the "->" button that appears. Note that some devices may display a "Go" button, while others will show "->".

your can reproduce this issue in any ionic 5 or ionic 6 version.

Code Reproduction URL

https://github.com/iStaha/time-picker/

Ionic Info

image

Additional Information

No response
@ionitron-bot ionitron-bot bot added the triage label Oct 11, 2023
@iStaha iStaha changed the title bug: datetime, go button doesn't do anything. bug: datetime, go button in number pad doesn't do anything. Oct 12, 2023
@liamdebeasi liamdebeasi changed the title bug: datetime, go button in number pad doesn't do anything. bug: datetime, go button in number pad doesn't do anything Oct 13, 2023
@liamdebeasi
Copy link
Contributor

Thanks! The keyboard should close when the "Go" button is pressed. This aligns with the behavior of https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/datetime-local on Android.

@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report labels Oct 13, 2023
@liamdebeasi liamdebeasi mentioned this issue Jan 17, 2024
Merged
2 tasks
@liamdebeasi
Copy link
Contributor

Here's a dev build with a proposed fix if you are interested in testing:

npm install @ionic/[email protected]

github-merge-queue bot pushed a commit that referenced this issue Jan 18, 2024
@liamdebeasi
fix(datetime): enter closes keyboard when typing time (#28848)
c47a16d 
Issue number: resolves #28325

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

When typing the time into the date picker pressing "Enter" does not
close the on-screen keyboard.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Pressing "Enter" closes the on-screen keyboard

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer
for more information.
-->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->


Test:

⚠️ While I have a test for this, please also test this on a physical
Android device.

1. Go to `src/components/datetime/test/basic`
2. Open the time picker (in any of the date times)
3. Tap the time to open the keyboard
4. Press "Enter" on Android. Observe that the keyboard closes.

Dev build: `7.6.6-dev.11705528328.1ef5e17b`
@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #28848, and a fix will be available in an upcoming release of Ionic Framework. Feel free to keep testing the dev build, and let me know if you run into any issues.

@ionitron-bot Ionitron Bot
Copy link

ionitron-bot bot commented Feb 17, 2024

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(datetime): enter closes keyboard when typing time ionic-team/ionic-framework
2 participants
@liamdebeasi @iStaha