Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: stencil does not transpile tsconfig aliases on 3.4.1 #27762

Closed
3 tasks done
mikaelkaron opened this issue Jul 7, 2023 · 4 comments · Fixed by #27765
Closed
3 tasks done

bug: stencil does not transpile tsconfig aliases on 3.4.1 #27762

mikaelkaron opened this issue Jul 7, 2023 · 4 comments · Fixed by #27765
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@mikaelkaron
Copy link

Prerequisites

Ionic Framework Version

v7.x

Current Behavior

when upgrading to 7.1.2 I get a bunch of errors similar to this one during build

[ WARN  ]  Bundling Warning UNRESOLVED_IMPORT
           '@utils/helpers' is imported by ../../node_modules/@ionic/core/dist/collection/components/input/input.js,
           but could not be resolved – treating it as an external dependency

Expected Behavior

no errors to display

Steps to Reproduce

Code Reproduction URL

No response

Ionic Info

n/a (not using ionic CLI)

Additional Information

this is a new regression in 7.1.2, downgrading to 7.1.1 fixes the problem
@ionitron-bot ionitron-bot bot added the triage label Jul 7, 2023
@liamdebeasi liamdebeasi self-assigned this Jul 7, 2023
@liamdebeasi
Copy link
Contributor

liamdebeasi commented Jul 7, 2023 •
edited
Loading

Thanks for the report. It looks like there was a Stencil regression that caused @utils/helpers (and other aliased paths) to not be transpiled to the correct relative path on build. I'll get in touch with the Stencil team to see if we can get this fixed on their end.

@liamdebeasi liamdebeasi changed the title bug: UNRESOLVED_IMPORT bug: stencil does not transpile tsconfig aliases on 3.4.1 Jul 7, 2023
@liamdebeasi liamdebeasi mentioned this issue Jul 7, 2023
Merged
2 tasks
@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report labels Jul 7, 2023
@ionitron-bot ionitron-bot bot removed the triage label Jul 7, 2023
@liamdebeasi
Copy link
Contributor

I am going to downgrade Stencil to 3.4.0 for now until the issue can be resolved on Stencil's side. Here is a dev build with the fix: 7.1.3-dev.11688736787.10e452c1

@liamdebeasi liamdebeasi removed their assignment Jul 7, 2023
github-merge-queue bot pushed a commit that referenced this issue Jul 7, 2023
@liamdebeasi
fix: avoid unresolved import warning on stencil apps (#27765)
2085025 
Issue number: resolves #27762

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

Stencil 3.4.1 regressed the tsconfig alias path transpilation. This is
fixed in 4.0.0 though.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Downgrade to Stencil 3.4.0. Stencil 4.0 has breaking changes, so I'd
like to wait on upgrading until we can work through any of the changes
that impact Ionic.

This reverts commit 9793b3c.


## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

Stencil issue: ionic-team/stencil#4550
@liamdebeasi
Copy link
Contributor

The PR has been merged, and the next release of Ionic will have this fix. In the meantime, you can either downgrade to 7.1.1 or use the dev build I provided in #27762 (comment). Thanks for reporting this!

@liamdebeasi liamdebeasi mentioned this issue Jul 7, 2023
Closed
2 tasks
@ionitron-bot
Copy link

ionitron-bot bot commented Aug 6, 2023

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: avoid unresolved import warning on stencil apps ionic-team/ionic-framework
2 participants
@mikaelkaron @liamdebeasi