fix(tab-button): use darker text to pass a11y #27355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
thetaPC
requested changes
May 3, 2023
mapsandapps
approved these changes
May 3, 2023
sean-perkins
reviewed
May 3, 2023
|
I updated this branch with |
|
Discussed with Brandy offline, but I manually removed the MD screenshots in 4c40f18 so they can be regenerated. The diff for the MD screenshots is too small to be detected with our current diff threshold of 0.1. However, I am hesitant to lower the threshold below 0.1 because we risk getting false positives with our screenshots. |
liamdebeasi
approved these changes
May 10, 2023
brandyscarney
added a commit
that referenced
this pull request
May 11, 2023
Issue number: N/A --------- - Changes the default Material Design tab color to `$text-color-step-350` or `#a6a6a6` - Changes the default iOS tab color to `$text-color-step-400` or `#999999` - Removes the axe skip in the e2e test These were the minimum color changes needed to pass axe. --------- Co-authored-by: ionitron <[email protected]> Co-authored-by: Liam DeBeasi <[email protected]>
brandyscarney
added a commit
that referenced
this pull request
May 11, 2023
This reverts commit 6aeb9ec.
brandyscarney
added a commit
that referenced
this pull request
May 22, 2023
This reverts commit 6aeb9ec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
$text-color-step-350or#a6a6a6$text-color-step-400or#999999These were the minimum color changes needed to pass axe.