Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: provide clearIcon property on ion-input #26974

Closed
3 tasks done
Spinnenzunge opened this issue Mar 16, 2023 · 2 comments · May be fixed by YoutacRandS-VA/eth2-beaconchain-explorer-app#2
Closed
3 tasks done

feat: provide clearIcon property on ion-input #26974

Spinnenzunge opened this issue Mar 16, 2023 · 2 comments · May be fixed by YoutacRandS-VA/eth2-beaconchain-explorer-app#2
Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement

Comments

@Spinnenzunge
Copy link

Prerequisites

Describe the Feature Request

With the PR #26354 the clear icon on an input component changed from background to rendered ion-icon. Since then it is not possible to brand the icon anymore.

Provide a clearIcon property to brand the clear icon on an ion-input component. The ion-searchbar component already supports this property.

Describe the Use Case

Consumers want to use their own icons for branding purposes but can not do that on the ion-input clear icon at the moment.

Describe Preferred Solution

No response

Describe Alternatives

No response

Related Code

No response

Additional Information

No response
@ionitron-bot ionitron-bot bot added the triage label Mar 16, 2023
@liamdebeasi liamdebeasi added type: feature request a new feature, enhancement, or improvement package: core @ionic/core package labels Mar 16, 2023
@ionitron-bot ionitron-bot bot removed the triage label Mar 16, 2023
@liamdebeasi liamdebeasi mentioned this issue Apr 1, 2024
Merged
2 tasks
liamdebeasi added a commit that referenced this issue Apr 2, 2024
@liamdebeasi
feat(input): add clearInputIcon property (#29246)
59b72f4 
Issue number: resolves #26974

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

In #26354 we updated
the clear icon to use an ionicon instead of an hardcoded SVG. This has
made it challenging to customize the icon.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Added `clearInputIcon` property to allow developers to customize the
ionicon used.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer
for more information.
-->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #29246, and the feature will be available in an upcoming release of Ionic Framework.

liamdebeasi added a commit that referenced this issue Apr 3, 2024
@liamdebeasi
feat(input): add clearInputIcon property (#29246)
0f5d1c0 
Issue number: resolves #26974

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

In #26354 we updated
the clear icon to use an ionicon instead of an hardcoded SVG. This has
made it challenging to customize the icon.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Added `clearInputIcon` property to allow developers to customize the
ionicon used.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer
for more information.
-->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
@ionitron-bot Ionitron Bot
Copy link

ionitron-bot bot commented May 2, 2024

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement
Projects
None yet
Milestone
No milestone
2 participants
@liamdebeasi @Spinnenzunge