Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fail build vue app in last update with vite #25485

Closed
5 of 7 tasks
KANekT opened this issue Jun 16, 2022 · 17 comments · Fixed by #25499
Closed
5 of 7 tasks

bug: fail build vue app in last update with vite #25485

KANekT opened this issue Jun 16, 2022 · 17 comments · Fixed by #25499
Labels
package: vue @ionic/vue package type: bug a confirmed bug report

Comments

@KANekT
Copy link

KANekT commented Jun 16, 2022

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x
  • Nightly

Current Behavior

Error after update to last version in vue, example file:

node_modules/@ionic/vue/dist/types/components/IonIcon.d.ts

in 6.1.10-nightly.20220614

export declare const IonIcon: import("vue").DefineComponent<{
    color: StringConstructor;
    flipRtl: BooleanConstructor;
    icon: StringConstructor;
    ios: StringConstructor;
    lazy: StringConstructor;
    md: StringConstructor;
    mode: StringConstructor;
    name: StringConstructor;
    size: StringConstructor;
    src: StringConstructor;
}, () => import("vue").VNode<import("vue").RendererNode, import("vue").RendererElement, {
    [key: string]: any;
}>, unknown, {}, {}, import("vue").ComponentOptionsMixin, import("vue").ComponentOptionsMixin, Record<string, any>, string, import("vue").VNodeProps & import("vue").AllowedComponentProps & import("vue").ComponentCustomProps, Readonly<{} & {
    lazy?: string;
    mode?: string;
    ios?: string;
    md?: string;
    name?: string;
    color?: string;
    size?: string;
    icon?: string;
    src?: string;
    flipRtl?: boolean;
}>, {}>;

in 6.1.10-nightly.20220615

export declare const IonIcon: import("vue").DefineComponent<{
    color: StringConstructor;
    flipRtl: BooleanConstructor;
    icon: StringConstructor;
    ios: StringConstructor;
    lazy: StringConstructor;
    md: StringConstructor;
    mode: StringConstructor;
    name: StringConstructor;
    size: StringConstructor;
    src: StringConstructor;
}, () => import("vue").VNode<import("vue").RendererNode, import("vue").RendererElement, {
    [key: string]: any;
}>, unknown, {}, {}, import("vue").ComponentOptionsMixin, import("vue").ComponentOptionsMixin, Record<string, any>, string, import("vue").VNodeProps & import("vue").AllowedComponentProps & import("vue").ComponentCustomProps, Readonly<import("vue").ExtractPropTypes<{
    color: StringConstructor;
    flipRtl: BooleanConstructor;
    icon: StringConstructor;
    ios: StringConstructor;
    lazy: StringConstructor;
    md: StringConstructor;
    mode: StringConstructor;
    name: StringConstructor;
    size: StringConstructor;
    src: StringConstructor;
}>>, {
    flipRtl: boolean;
}>;

Expected Behavior

<ion-icon slot="icon-only" :icon="icons.close" />

Type string is not assignable to type InferPropType
Type string is not assignable to type [StringConstructor] extends [Prop<infer V, infer D>] ? (unknown extends infer V ? IfAny<V, V, D> : V) : StringConstructor     
Type string is not assignable to type StringConstructor

Steps to Reproduce

vue-tsc --noEmit && vite build

Code Reproduction URL

No response

Ionic Info

Ionic:

Ionic CLI : 6.18.1 (C:\Users\KANekT\AppData\Roaming\npm\node_modules@ionic\cli)

Capacitor:

Capacitor CLI : 3.5.1
@capacitor/android : 3.5.1
@capacitor/core : 3.5.1
@capacitor/ios : 3.5.1

Utility:

cordova-res : not installed globally
native-run : 1.6.0

System:

NodeJS : v16.15.1 (C:\Program Files\nodejs\node.exe)
npm : 8.11.0
OS : Windows 10

Additional Information

No response

@ionitron-bot ionitron-bot bot added the triage label Jun 16, 2022
@KANekT KANekT changed the title bug: fail build in last update bug: fail build vue app in last update Jun 16, 2022
@reslear
Copy link

reslear commented Jun 16, 2022

vue version?

@KANekT
Copy link
Author

KANekT commented Jun 16, 2022

Vue 3

@liamdebeasi
Copy link
Contributor

Thanks for the issue. Can you provide a GitHub repo that I can use to verify this behavior?

@liamdebeasi liamdebeasi added the needs: reply the issue needs a response from the user label Jun 16, 2022
@ionitron-bot ionitron-bot bot removed the triage label Jun 16, 2022
@reslear
Copy link

reslear commented Jun 16, 2022

@KANekT это очевидно что 3, полная версия, и версия vite?

@ionitron-bot ionitron-bot bot added triage and removed needs: reply the issue needs a response from the user labels Jun 16, 2022
@reslear
Copy link

reslear commented Jun 16, 2022

hi @liamdebeasi I have a similar problem, but not with build, but with volar vscode ext
Screenshot 2022-06-16 at 17 01 23
repro https://github.com/reslear/ionic-vue-pnpm-express-monorepo

@liamdebeasi
Copy link
Contributor

Ionic Vue does not support Volar. See: #24169

@liamdebeasi liamdebeasi added the needs: reply the issue needs a response from the user label Jun 16, 2022
@ionitron-bot ionitron-bot bot removed the triage label Jun 16, 2022
@KANekT
Copy link
Author

KANekT commented Jun 17, 2022

@liamdebeasi @reslear i update to vite and last version repo:
https://github.com/KANekT/ion-menu-bug

i have warning in webstorm
изображение

and error in build

@ionitron-bot ionitron-bot bot added triage and removed needs: reply the issue needs a response from the user labels Jun 17, 2022
@KANekT KANekT changed the title bug: fail build vue app in last update bug: fail build vue app in last update with vite Jun 17, 2022
@liamdebeasi liamdebeasi self-assigned this Jun 17, 2022
@liamdebeasi
Copy link
Contributor

Thanks! I can reproduce this behavior, and I am investigating.

@liamdebeasi
Copy link
Contributor

Can everyone try the following dev build and let me know if it resolve the issue?

npm install @ionic/[email protected] @ionic/[email protected]

@KANekT
Copy link
Author

KANekT commented Jun 17, 2022

Yes it resolve this error

@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #25499, and a fix will be available in an upcoming release of Ionic Framework.

@kachidk
Copy link

kachidk commented Jun 22, 2022

Ionic Vue does not support Volar. See: #24169

Is there a recommendation on what to use instead?

@reslear
Copy link

reslear commented Jun 22, 2022

@kachidk volar is support, but without html types, i'm use everyday - no problems

@kachidk
Copy link

kachidk commented Jun 22, 2022

I have a similar problem, but not with build, but with volar vscode ext

174087197-be6f1951-ec34-4704-b43f-f25414a584a1

I have this same problem similar to you have did you solve it

@liamdebeasi
Copy link
Contributor

Hi everyone,

This issue was resolved in Ionic 6.1.11. Please update to the latest version of Ionic Vue to receive a fix for this issue.

@liamdebeasi
Copy link
Contributor

Also, as per my comment in #25485 (comment), Volar support should be improved in Ionic 6.1.11. Please give it a try and let us know if you run into any issues on #24169.

@ionitron-bot
Copy link

ionitron-bot bot commented Jul 22, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: vue @ionic/vue package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants