Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ion-item with solid fill inside ion-accordion content is missing bottom border in md-mode #24613

Closed
4 of 6 tasks
PhilippeKayser opened this issue Jan 20, 2022 · 3 comments · Fixed by #24618
Closed
4 of 6 tasks
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@PhilippeKayser
Copy link

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x

Current Behavior

Having an ion-item with fill="solid" inside an ion-accordion, the bottom border is missing when mode is md. ion-item is correctly rendered when mode is ios.

Expected Behavior

The ion-item should have the bottom border visible

Steps to Reproduce

Implementation reproducing the issue is available in the repository provided.

Code Reproduction URL

https://github.com/PhilippeKayser/ion-accordion-bug

Ionic Info

Ionic:

Ionic CLI : 6.18.1 (/Users/philippe/.config/yarn/global/node_modules/@ionic/cli)
Ionic Framework : @ionic/angular 6.0.3
@angular-devkit/build-angular : 13.1.4
@angular-devkit/schematics : 12.2.15
@angular/cli : 13.1.4
@ionic/angular-toolkit : 5.0.3

Capacitor:

Capacitor CLI : 3.4.0
@capacitor/android : not installed
@capacitor/core : 3.4.0
@capacitor/ios : not installed

Utility:

cordova-res (update available: 0.15.4) : 0.15.3
native-run : 1.5.0

System:

NodeJS : v16.13.1 (/usr/local/bin/node)
npm : 8.3.0
OS : macOS Monterey

Additional Information

I'm not sure, but it seems a bit like the border is "there" but just overlayed by something else, as the border appears when focused, but a bit thinner than if it weren't in the accordion component. I hope you see what I mean.

@ionitron-bot ionitron-bot bot added the triage label Jan 20, 2022
@liamdebeasi liamdebeasi self-assigned this Jan 20, 2022
@liamdebeasi
Copy link
Contributor

Thanks, I can reproduce this. The issue is that our styles intend to remove the border on the ion-item in the header of an accordion, but we target all ion-item elements inside of an accordion, resulting in this issue: https://github.com/ionic-team/ionic-framework/blob/main/core/src/css/core.scss#L285

@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #24618, and a fix will be available in an upcoming release of Ionic Framework.

@ionitron-bot
Copy link

ionitron-bot bot commented Feb 20, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Feb 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants