bug: isDismissing on Overlay is scoped to exported IonModal class and not instances of the IonModal.

[puopg]

Prequisites

• I have read the Contributing Guidelines.
• I agree to follow the Code of Conduct.
• I have searched for existing issues that already report this problem, without success.

Ionic Framework Version

• v4.x
• v5.x
• v6.x

Current Behavior

Speaking on behalf of ionic/react: 5.7.0.

IonModal will mount child components even if isOpen is hardcoded to false due to the isDismissing flag on the createOverlayComponent HOC.

Expected Behavior

If IonModal isOpen is hardcoded to false, I would expect my child component NEVER gets mounted. Like why would it lol?

Steps to Reproduce

You need to have multiple IonModals being rendered. Then as you dismiss one using simple setState boolean toggles lets say, you will notice that other IonModals will see isDismissing as true, even if isOpen is hardcoded to false. And that causes the inner children to mount.

Code Reproduction URL

No response

Ionic Info

No response

Additional Information

I think this is due to the isDismissing flag being scoped to the createOverlayComponent and not the instance of the Overlay class / IonModal instance. Shouldn't each IonModal be independent of the others?

[puopg]

Obviously, I don't know if this is actually an oversight or a feature (if so I'd love to be enlightened what is the feature), but I figured I can link a simple fix if it actually is: #23903

[liamdebeasi]

Thanks! You are correct, the isDismissing state should be unique to each instance of IonModal. I will take a look at your PR shortly.

[liamdebeasi]

Thanks for the issue. This has been resolved via #23903, and a fix will be available in an upcoming release of Ionic Framework.

[ionitron-bot]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.