Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(tab-bar): safe area padding not added when slot="top" #23893

Closed
4 of 6 tasks
EinfachHans opened this issue Sep 8, 2021 · 2 comments · Fixed by #23895
Closed
4 of 6 tasks

bug(tab-bar): safe area padding not added when slot="top" #23893

EinfachHans opened this issue Sep 8, 2021 · 2 comments · Fixed by #23895
Labels
package: core @ionic/core package type: bug a confirmed bug report
Milestone

Comments

@EinfachHans
Copy link
Contributor

Prequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x

Current Behavior

We use a <ion-tab-bar> that is placed with slot="top". This seems to not respect the safe area for the top

Expected Behavior

To have a padding-top: var(--ion-safe-area-top, 0); in a top placed tab bar

Steps to Reproduce

  • Tabs Starter
  • Place it on top

Code Reproduction URL

No response

Ionic Info

No response

Additional Information

No response

@ionitron-bot ionitron-bot bot added the triage label Sep 8, 2021
@liamdebeasi liamdebeasi changed the title bug(tab-bar): Safe area for top placed bug(tab-bar): safe area padding not added when slot="top" Sep 8, 2021
@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report labels Sep 8, 2021
@ionitron-bot ionitron-bot bot removed the triage label Sep 8, 2021
@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #23895, and a fix will be available in an upcoming release of Ionic Framework.

@ionitron-bot
Copy link

ionitron-bot bot commented Oct 13, 2021

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants