Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ion-label slot end should not use flex and be right aligned by default #23806

Closed
4 of 6 tasks
infacto opened this issue Aug 24, 2021 · 2 comments · Fixed by #23807
Closed
4 of 6 tasks

bug: ion-label slot end should not use flex and be right aligned by default #23806

infacto opened this issue Aug 24, 2021 · 2 comments · Fixed by #23807
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@infacto
Copy link

infacto commented Aug 24, 2021

Prequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x

Current Behavior

image

All elements of items which are slotted to end should not use the flex width and should be right aligned by default.
Especially input field. (ion-input)

Expected Behavior

image

ion-label[slot='end'] {
  flex: unset;
  text-align: end;
}

This is my current workaround in global styles. (text-align: end on inline elements takes effect when multiple rows with different widths are present.)

Steps to Reproduce

<ion-item>
  <ion-label>Demo</ion-label>
  <ion-label slot="end">Test</ion-label>
</ion-item>

I wonder why does Ionic have this behavior / styles? What do you think about my proposal of right aligned inline end slot? Why not? Looks more complete. I just created this issue as bug because unexpected behavior.

@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #23807, and a fix will be available in an upcoming release of Ionic Framework.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 23, 2021

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants