Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: toast with icon #23524

Closed
infacto opened this issue Jun 28, 2021 · 2 comments · Fixed by #23596
Closed

feat: toast with icon #23524

infacto opened this issue Jun 28, 2021 · 2 comments · Fixed by #23596
Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement
Milestone
6.0.0-beta.3

Comments

@infacto
Copy link

infacto commented Jun 28, 2021

Feature Request

Ionic version:
[ ] 4.x
[x] 5.x
[ ] 6.x

Describe the Feature Request
A toast with an icon would be nice. The buttons can already have an icon. But the message itself should have an optional icon at slot start.

https://ionicframework.com/docs/api/toast

image
Just a photo montage.

Related Code

const toast = await this.toastController.create({
  header: 'Toast header',
  message: 'Click to Close',
  icon: 'bug', // <- new property
});
@ionitron-bot ionitron-bot bot added the triage label Jun 28, 2021
@infacto infacto changed the title feat: Toasts with icons. feat: Toast with icon. Jun 28, 2021
@liamdebeasi liamdebeasi changed the title feat: Toast with icon. feat: toast with icon Jun 28, 2021
@liamdebeasi liamdebeasi added package: core @ionic/core package type: feature request a new feature, enhancement, or improvement labels Jun 28, 2021
@ionitron-bot ionitron-bot bot removed the triage label Jun 28, 2021
domske added a commit to domske/ionic-framework that referenced this issue Jul 8, 2021
@domske
feat(toast): optional icon.
f8cd175 
resolves ionic-team#23524
@domske domske mentioned this issue Jul 8, 2021
Merged
13 tasks
@liamdebeasi liamdebeasi added type: feature request a new feature, enhancement, or improvement and removed type: feature request a new feature, enhancement, or improvement labels Jul 20, 2021
@liamdebeasi liamdebeasi added this to the 6.0.0-beta.3 milestone Jul 21, 2021
liamdebeasi added a commit that referenced this issue Jul 23, 2021
@domske @willmartian @liamdebeasi
feat(toast): add icon property to show icon at start of toast content (…
df24c8c 
…#23596)

resolves #23524

Co-authored-by: William Martin <[email protected]>
Co-authored-by: Liam DeBeasi <[email protected]>
@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #23596, and this feature will be in the next Framework v6 beta.

@ionitron-bot
Copy link

ionitron-bot bot commented Aug 22, 2021

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement
Projects
None yet
Milestone
6.0.0-beta.3
Development

Successfully merging a pull request may close this issue.

feat(toast): add icon property to show icon at start of toast content domske/ionic-framework
2 participants
@liamdebeasi @infacto