Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: angular, isAnimating() not defined on menu controller provider #20053

Closed
nogamenofun98 opened this issue Dec 10, 2019 · 2 comments · Fixed by #28618
Closed

bug: angular, isAnimating() not defined on menu controller provider #20053

nogamenofun98 opened this issue Dec 10, 2019 · 2 comments · Fixed by #28618
Labels
package: angular @ionic/angular package type: bug a confirmed bug report

Comments

@nogamenofun98
Copy link

nogamenofun98 commented Dec 10, 2019

Ionic version:
4.11.5

Current behavior:
when i import menu controller into a page component, i saw from the official ionic website listed got a method to detect is the menu animating or not. Link to Doc

image

but i couldn't find the method when writing code, IDE prompting method not found during compile and browser also say method not found.

Expected behavior:
it should be able to find the method and return the menu is animating or not.

Steps to reproduce:

  1. just import the menu controller in any module, and write like this.menu.isAnimating(), it will show not found error

Related code:

Ionic info:

image

image

Ionic Info

Ionic:

   ionic (Ionic CLI)             : 4.11.0 (C:\Users\oks\AppData\Roaming\npm\node_modules\ionic)
   Ionic Framework               : @ionic/angular 4.11.5
   @angular-devkit/build-angular : 0.801.3
   @angular-devkit/schematics    : 8.1.3
   @angular/cli                  : 8.1.3
   @ionic/angular-toolkit        : 2.1.1

Cordova:

   cordova (Cordova CLI) : 8.1.2 ([email protected])
   Cordova Platforms     : browser 5.0.4
   Cordova Plugins       : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 4.1.3, (and 5 other plugins)

System:

   NodeJS : v10.15.3 (D:\Program\nodejs\node.exe)
   npm    : 6.4.1
   OS     : Windows 10
@ionitron-bot ionitron-bot bot added the triage label Dec 10, 2019
@nogamenofun98 nogamenofun98 changed the title bug: isAnimating() function missing from ionic menu controller bug: isAnimating() method missing from ionic menu controller Dec 10, 2019
@liamdebeasi liamdebeasi changed the title bug: isAnimating() method missing from ionic menu controller bug: angular, isAnimation() not defined on menu controller provider Feb 8, 2022
@liamdebeasi liamdebeasi added package: angular @ionic/angular package type: bug a confirmed bug report labels Feb 8, 2022
@ionitron-bot ionitron-bot bot removed the triage label Feb 8, 2022
@liamdebeasi liamdebeasi changed the title bug: angular, isAnimation() not defined on menu controller provider bug: angular, isAnimating() not defined on menu controller provider Feb 8, 2022
@liamdebeasi liamdebeasi added type: bug a confirmed bug report and removed type: bug a confirmed bug report labels Oct 27, 2023
github-merge-queue bot pushed a commit that referenced this issue Dec 5, 2023
Issue number: resolves #20053 

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

There are a few methods that that are missing for the menu in the
Angular packages. This leads to users to not being able to use methods
like `isAnimating()`.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- The missing methods have been added by implementing `MenuControllerI`.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

Dev build: 7.5.8-dev.11701461830.1be851fd
@thetaPC
Copy link
Contributor

thetaPC commented Dec 5, 2023

Thanks for the issue! This has been resolved via PR #28618 and will be available in an upcoming release of Ionic.

Copy link

ionitron-bot bot commented Jan 4, 2024

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: angular @ionic/angular package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants