Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collection-repeat: Order is not preserved #1806

Closed
michelalbers opened this issue Jul 18, 2014 · 35 comments
Closed

collection-repeat: Order is not preserved #1806

michelalbers opened this issue Jul 18, 2014 · 35 comments
Milestone

Comments

@michelalbers
Copy link

Hi,

if you use collection-repeat with several items the order of the items is not preserved. You can specify a track by function on your own but that doesn't change anything.

best,
Michel

@ajoslin
Copy link
Contributor

ajoslin commented Jul 18, 2014

Hi @michelalbers, what do you mean by 'not preserved'?

Could you post a codepen?

@michelalbers
Copy link
Author

I use Collection-Repeat with Images in a 3 Column Grid. When scrolling up or down the elements change their order.

I will provide a codepen if further information is needed.

Am 19 Jul 2014 um 01:40 schrieb Andrew Joslin [email protected]:

Hi @michelalbers, what do you mean by the 'not preserved'?


Reply to this email directly or view it on GitHub.

@ajoslin
Copy link
Contributor

ajoslin commented Jul 19, 2014

Yes, I think I understand the problem now. Could you post a codepen anyway?

@mhartington
Copy link
Contributor

So not really the set-up described above, but the issue is there.

http://codepen.io/mhartington/pen/dzLEo

@h4ck3rviv3k
Copy link

I am also facing similar kind of issues Please have a look into it 👍

#1842

@adamdbradley adamdbradley modified the milestone: 1.0.0-beta11 Jul 28, 2014
@timmyg
Copy link

timmyg commented Aug 15, 2014

+1

@timmyg
Copy link

timmyg commented Aug 20, 2014

This doesnt appear fixed in the codepen even with the nightly build. It looks like the new code is in the nightly build js, but it is sitll "clicking" a list item further down in the page when you click one at the top. Didnt work for me in my project either. @mhartington

@timmyg
Copy link

timmyg commented Sep 3, 2014

@ajoslin any ideas on this one? It's holding up our app from being released. Have a checklist and it is checking items further down the list, confusing users obviously. Am happy to dig in if you can get me started.

@adamdbradley adamdbradley modified the milestones: 1.0.0-beta12, 1.0.0-rc0 Sep 12, 2014
@timmyg
Copy link

timmyg commented Oct 4, 2014

+1 :)

@alextrs
Copy link

alextrs commented Nov 3, 2014

We use 1.0.0-beta 12 and have the same issue, any ideas on when you are going to fix it?

@krlwlfrt
Copy link

+1

@timmyg
Copy link

timmyg commented Dec 19, 2014

does anyone have any idea/hack for this bug? Spent a few hours on it but not getting anywhere... @ballmw I know you've done some ionic :)

@mixersoft
Copy link

+1

3 similar comments
@pulakb
Copy link

pulakb commented Jan 9, 2015

+1

@benjoz
Copy link

benjoz commented Jan 9, 2015

+1

@unr
Copy link

unr commented Jan 22, 2015

👍

@tslater
Copy link

tslater commented Feb 3, 2015

+1 What is that status on this? Is it being worked on or should I just abandon collection repeat for now?

@unr
Copy link

unr commented Feb 4, 2015

Currently, I've been using Infinite Scroll instead.

@ajoslin
Copy link
Contributor

ajoslin commented Feb 6, 2015

Working on this now.

@ajoslin
Copy link
Contributor

ajoslin commented Feb 6, 2015

Can you guys try this in the nightly build? This should be fixed.

@ajoslin ajoslin closed this as completed in 34e350b Feb 6, 2015
@ajoslin ajoslin removed the ready label Feb 6, 2015
@timmyg
Copy link

timmyg commented Feb 6, 2015

@ajoslin if you try @mhartington's codepen from above (http://codepen.io/mhartington/pen/dzLEo) it still doesnt seem to be working, and that one appears to be using the nightly.

It seems to hide it now, but it also isn't there when you scroll back up (try swiping over one of the top ones, scrolling out of the screen, then scrolling back up)

@ajoslin
Copy link
Contributor

ajoslin commented Feb 7, 2015

So this issue is for items losing their order while scrolling. The item swiping is a separate bug.

See #1842 (comment)

@tslater
Copy link

tslater commented Feb 7, 2015

I don't know if this is the exact same, but my observation is that if I add
items to the list (eg. infinte scroll), that the order gets crazy weird.

On Fri, Feb 6, 2015 at 5:32 PM, Andrew Joslin [email protected]
wrote:

So this issue is for items losing their order while scrolling. The item
swiping is a separate bug.

See #1842 (comment)
#1842 (comment)


Reply to this email directly or view it on GitHub
#1806 (comment).

@kparks29
Copy link

I am using the latest release v1.0.0-rc.1 and I still seem to have this same issue.
Can we reopen this issue?

When I am scrolling down and then back up the order gets jumbled.

@mhartington
Copy link
Contributor

@kparks29 are you seeing this in just a normal collection-repeat demo? Or are you including things like option buttons and infinite scroll? Could you post a codepen of this?

@kparks29
Copy link

i noticed it in my own custom one, I actually had 1 way data binding on the child elements and found out that was the issue. Didn't know 1 way data binding would cause an issue on the children, I knew I couldnt have it on the collection repeat itself.

Also are there any updates on the image performance lag for the collection repeat?

@mhartington
Copy link
Contributor

One-way data binding is not advised.
We can't update the data of the elements if all the watchers are disconnected.

http://ionicframework.com/docs/api/directive/collectionRepeat/

@ace-han
Copy link

ace-han commented Nov 29, 2015

@tslater the same situation +1.
@mhartington already NOT using one-way binding. And still got weird order to display and using v1.1.1

@RobiFerentz
Copy link

This issue is really annoying. Any ideas for an actual fix?

@Screeze
Copy link

Screeze commented Dec 20, 2015

Also facing this issue, especially when adding items (e.g. using ion-infinite-scroll)

@kinkay716
Copy link

Also facing this issue while using in conjunction with infinite-scroll. help?

@christopherfowers
Copy link

Is there an update on this issue?

@ctesene
Copy link

ctesene commented Feb 2, 2016

I see the issue in iOS, but not in the browser. Can this be re-opened?

@leonardobazico
Copy link

+1

@ghost
Copy link

ghost commented Sep 27, 2016

Also seeing this problem in conjunction with infinite scroll. The scroll position jumps up and then back down sometimes when appending to the Array.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests