Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ion-item should allow overflow css variable #17670

Closed
tompap opened this issue Mar 3, 2019 · 5 comments · Fixed by #18502
Closed

ion-item should allow overflow css variable #17670

tompap opened this issue Mar 3, 2019 · 5 comments · Fixed by #18502
Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement

Comments

@tompap
Copy link

tompap commented Mar 3, 2019

Feature Request

Ionic version:
[x] 4.x

Describe the Feature Request

Currently item-inner and input-wrapper add some overflow:hidden, but due to webcomponent and how there are working it's not possible to override this settings.
We have a custom input that should be over the input but not possible due to overflow:hidden

@ionitron-bot ionitron-bot bot added the triage label Mar 3, 2019
@brandyscarney
Copy link
Member

Thank you for the issue! Do you have an example of the HTML / CSS you are using so we can reproduce the issue and make sure we understand the use case? Here's a sample Ionic 4 Codepen if you would like to fork it: https://codepen.io/pen?template=aXENNW

@brandyscarney brandyscarney added the needs: reply the issue needs a response from the user label Mar 4, 2019
@ionitron-bot ionitron-bot bot removed the triage label Mar 4, 2019
@uniquejava
Copy link

uniquejava commented Mar 25, 2019

I have the same request. My .error class has a style of position: absolute; bottom: -2px and I'd like this nested .error element sit on top of ion-item bottom border.
However the ion-item's overflow is hidden. It's covering my error element. I'd like to set ion-item's over flow as visible.

  <ion-item>
        <ion-label position="fixed">PIN</ion-label>
        <ion-input
          type="number"
          pattern="[0-9]*"
          (keydown)="onKeyDownLimitLength($event, 7)"
          inputmode="numeric"
          formControlName="acct_no"
        ></ion-input>
        <span class="error">Please you need to enter 7 digits!</span>
      </ion-item>

@ionitron-bot ionitron-bot bot added triage and removed needs: reply the issue needs a response from the user labels Mar 25, 2019
@uniquejava
Copy link

uniquejava commented Mar 25, 2019

@brandyscarney Hi, I created some sample codepen code snippet here: https://codepen.io/uniquejava/pen/OqqyOj

You see the message Please you need to enter 7 digits! is not showing correctly.

The following are some visual effect we'd like to implement.

Thank you.

image

@brandyscarney brandyscarney added type: feature request a new feature, enhancement, or improvement package: core @ionic/core package labels Mar 25, 2019
@ionitron-bot ionitron-bot bot removed the triage label Mar 25, 2019
@anagstef
Copy link
Contributor

Hello! I have a case where overflow is needed for ion-item here: https://codepen.io/masimakopoulos/pen/oRPyKx

Also, I've opened a PR (#18410) adding this feature, where overflow css variable is exposed.

@ionitron-bot
Copy link

ionitron-bot bot commented Jul 11, 2019

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants