Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whole view can be moved up and down #1609

Closed
alexbainbridge opened this issue Jun 12, 2014 · 30 comments
Closed

Whole view can be moved up and down #1609

alexbainbridge opened this issue Jun 12, 2014 · 30 comments
Labels
needs: reply the issue needs a response from the user

Comments

@alexbainbridge
Copy link

Issue #1218 is the previous example of this (not sure whether you prefer to reopen that or create a new one)

6 beta
ios - on device

@shprink has a codepen (on 1218) that recreates it (in latest code)

Ideally the entire view should not move (i.e header / footer stays static)

@ajoslin
Copy link
Contributor

ajoslin commented Jun 12, 2014

Are you able to reproduce this on a device in cordova?

@alexbainbridge
Copy link
Author

IOS on an iphone yes (issue only seems to have arrived recently, I could try rolling back a few beta versions if that would help narrow where it came from)

@shprink may be able to recreate too?

@ajoslin
Copy link
Contributor

ajoslin commented Jun 12, 2014

Is this ios7 or ios6?

@alexbainbridge
Copy link
Author

IOS 7.1.1

@ajoslin
Copy link
Contributor

ajoslin commented Jun 12, 2014

OK, I'll test @shprink's codepen on device.

@ajoslin
Copy link
Contributor

ajoslin commented Jun 12, 2014

@alexbainbridge we're unable to reproduce using this exact codepen in a cordova app on an iphone 5s, running nightly.

http://codepen.io/shprink/pen/ugFCI

Do you have exact steps to reproduce?

@alexbainbridge
Copy link
Author

OK I am on 6 beta - let me try with nightly. This won't be until tomorrow probably now, sadly.

@ajoslin
Copy link
Contributor

ajoslin commented Jun 12, 2014

OK. We will release beta7 today anyway, then. @shprink are you able to test on nightly?

@shprink
Copy link

shprink commented Jun 12, 2014

I do not know if this issue tend to demonstrate the problem I originally highlighted with this codepen but anyway the problem still exist with nightly : http://codepen.io/shprink/pen/hfCeK

The side menu that is present within the modal is not shown.

@ajoslin
Copy link
Contributor

ajoslin commented Jun 12, 2014

Ok, that is a different issue. Are you able to slide the whole webview up and down?

@shprink
Copy link

shprink commented Jun 12, 2014

Are you able to slide the whole webview up and down?

Yes it seems ok

@alexbainbridge
Copy link
Author

ok - hang on - I will check with 7 when its out. I will close if fixed, or will create steps to reproduce if not

@ajoslin
Copy link
Contributor

ajoslin commented Jun 12, 2014

@shprink do you mean yes you can slide the webview, or no you can't?

@shprink
Copy link

shprink commented Jun 12, 2014

I was included in this conversation against my will lol!

I do not really understand the issue, so I will not answer your question (do not want to mislead you). What I can say is YES it seems to work correctly for me (The header is static, I can scroll the list etc.)

@ajoslin
Copy link
Contributor

ajoslin commented Jun 12, 2014

Haha sorry :-). All seems good then.
On Jun 12, 2014 9:26 AM, "Julien Renaux" [email protected] wrote:

I was included in this conversation against my will lol!

I do not really understand the issue, so I will not answer your question
(do not want to mislead you). What I can say is YES it seems to work
correctly for me (The header is static, I can scroll the list etc.)


Reply to this email directly or view it on GitHub
#1609 (comment).

@alexbainbridge
Copy link
Author

Sorry about that @shprink - ha - I thought you had been able to see the problem on the other ticket !

Good news @ajoslin is that 7 doesn't have it..... goodness knows what is going on - but ha - lets close this!

@toby-m
Copy link

toby-m commented Jul 11, 2014

I'm still (again?) seeing this with beta9. Any header or footer or screen that doesn't scroll can be used to pull the whole app down to nearly 50% of the screen being black. The iOS battery/clock/etc become invisible against the black background.

@toby-m
Copy link

toby-m commented Jul 11, 2014

This is on iPhone 4S with iOS 7.1, Ionic beta 9

img_0934
img_0935

@CoenWarmer
Copy link

In at least one occurrence of this bug, this would happen when using an ion-footer-bar with an ion-content. Is that the case in your app? If not, please provide code that reproduces this bug.

@ajoslin
Copy link
Contributor

ajoslin commented Jul 11, 2014

This bug is so hard to track down. Yes, reproducible code would be great.

@alexbainbridge
Copy link
Author

I think my fix came when I added ion-pane around everything in the body, in index.html

@toby-m
Copy link

toby-m commented Jul 11, 2014

I'm not going to get a chance to work out a fully reproducible app right now (it's 4:30pm on Friday here) but I can give you an overview of what we've got.

Every view we have (excepting some modals) uses an ion-content, some of them have scrollable content inside them that works normally. We only have ion-footers on our modals and the drag on the footer is a slightly different sort of broken where I can pull the black up over the app but the app doesn't move.

img_2729

From index.html:

    <ion-nav-bar class="nav-title-slide-ios7 bar-positive" se-locale="labels" ng-cloak>
        <ion-nav-back-button class="button-icon button-calm button-clear"><i class="icon ion-ios7-arrow-back"></i> {{labels.dealListTabTitle}}</ion-nav-back-button>
    </ion-nav-bar>
    <toaster-container toaster-options="{'time-out': 3000, 'close-button':false, 'position-class':'toast-bottom-full-width'}"></toaster-container>
    <ion-nav-view></ion-nav-view>

All of our views have a tab bar across the bottom, from routes.js:

$stateProvider
            .state("tab", {
                url: "",
                abstract: true,
                templateUrl: "se/shared/tabs.html"
            })
            .state("tab.deals-index", {
                url: "/",
                views: {
                    "deals-tab": {
                        templateUrl: "se/deals/deals.html",
                        controller: "dealsController"
                    }
                }
            })
... more like that

tabs.html:

<ion-tabs class="tabs-icon-top tabs-default" data-se-locale="labels">
    <ion-tab title="{{labels.dealListTabTitle}}" icon="ion-sedeals" href="#/deals">
        <ion-nav-view name="deals-tab"></ion-nav-view>
    </ion-tab>
... all our tabs are similar to that

From that first tab view, it has an ion-content that scrolls normally but the header/tabs can be used to drag the app.

<ion-view se-locale="labels" title="{{selectedStateName() || labels.noLocationTitle}}" hide-back-button="true">
    <ion-nav-buttons side="left">
        <button class="button button-icon" se-location-selection="updateLocation">
            <i class="icon ion-location"></i>
        </button>
    </ion-nav-buttons>
...
<ion-content class="has-subheader">
            <ion-list>
                <ion-item collection-repeat=...>
                  ...
                </ion-item>
            </ion-list>
        </ion-content>
    </div>
</ion-view>

I'm not sure what else I can tell you.
@alexbainbridge Thanks, I'll give the ion-pane thing a try on Monday.

@ajoslin
Copy link
Contributor

ajoslin commented Jul 11, 2014

It may be a combination of tab and header then. Interesting...

@ajoslin ajoslin reopened this Jul 11, 2014
@martihag
Copy link

I've been having the same problem on iOS 7 emulator with beta (have not tried earlier versions) 7,8 and now 9 as well. I am not using tabs, so I do not think the problem is strictly connected to that.

my index.html is simply

<body ng-app="myApp">
    <ion-nav-view></ion-nav-view>
</body>

With a typical view being: (within all my views I can scroll the whole screen, and some has footer, some don't.) What is common between all views, is that they all have their own header in the template.

<ion-view title="someView">
  <ion-header-bar class="bar-energized">
    <a ui-sref="friends" class="button button-icon icon ion-ios7-people"></a>
    <h1 class="title">myApp</h1>
    <a ui-sref="settings" class="button button-icon icon ion-ios7-settings-strong"></a>
  </ion-header-bar>
  <ion-content>
    <div class="list">
      <a class="item item-icon-left" href="#" ng-repeat="item in items">
        <i class="icon ion-alert" ng-class="{'icon ion-checkmark': item.opened}"></i>
        <h2>{{item.data}}</h2>
        <div class="tags">{{item.tags.join(', ')}}</div>
        <div class="info">{{item.from}}, <span am-time-ago="item.date"></span></div>
      </a>
    </div>
  </ion-content>
  <a ui-sref="compose">
    <div class="bar bar-footer bar-energized">
      <h1 class="title">Make Thing</h1>
    </div>
  </a>
</ion-view>

@mhartington
Copy link
Contributor

Can we confirm that this is no longer an issue?

@toby-m
Copy link

toby-m commented Aug 13, 2014

We still get this is beta11.

@mhartington
Copy link
Contributor

@toby-m, lets move this to the forum for now.

http://forum.ionicframework.com/t/being-able-to-drag-the-app-view/8170

@alexbainbridge
Copy link
Author

I originated this issue - and closed it previously when a fix was found (ion-pane) - so Ionic team do close when you wish if you are taking this to the forums ! @mhartington

@famebo
Copy link

famebo commented Mar 28, 2018

Hi, i know this is old post but this answer might be help if someone needed.

#1218 you can find the solution here which i wrote down too.

<preference name="DisallowOverscroll" value="true" />

In config.xml just set it true and try it again.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 1, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: reply the issue needs a response from the user
Projects
None yet
Development

No branches or pull requests

8 participants