Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4: State property on ion-item isn't documented #15690

Closed
camwiegert opened this issue Sep 20, 2018 · 1 comment · Fixed by #15856
Closed

v4: State property on ion-item isn't documented #15690

camwiegert opened this issue Sep 20, 2018 · 1 comment · Fixed by #15856
Assignees
@manucorporat
Labels
package: core @ionic/core package

Comments

@camwiegert
Copy link
Contributor

The state property on ion-item is being pulled into the docs, but lacks a description. We should document it or exclude it from the docs.
@camwiegert camwiegert added docs package: core @ionic/core package labels Sep 20, 2018
brandyscarney added a commit that referenced this issue Oct 4, 2018
@brandyscarney
fix(item): add input highlight using an absolute div
9592723 
Adds the following CSS properties to item:

```
--highlight-color-focused
--highlight-color-valid
--highlight-color-invalid
--highlight-height
```

This also fixes an issue where we were showing the highlight on items
with no lines, and shows inset vs full properly.

fixes #14036 fixes #9639 fixes #14952 closes #15690
@brandyscarney brandyscarney mentioned this issue Oct 4, 2018
Merged
brandyscarney added a commit that referenced this issue Oct 5, 2018
@brandyscarney
fix(item): add input highlight using an absolute div (#15856)
f885f7d 
Adds the following CSS properties to item:

```
--highlight-color-focused
--highlight-color-valid
--highlight-color-invalid
--highlight-height
```

This also fixes an issue where we were showing the highlight on items
with no lines, and shows inset vs full properly. Adds documentation and tests for input focus.

fixes #14036 fixes #9639 fixes #14952 closes #15690
@ionitron-bot
Copy link

ionitron-bot bot commented Nov 4, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@manucorporat manucorporat

Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(item): add input highlight using an absolute div ionic-team/ionic-framework
2 participants
@manucorporat @camwiegert