Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionic serve on cancel is not killing the node process in the background #14983

Closed
IsaacSomething opened this issue Aug 2, 2018 · 3 comments
Closed
Labels

Comments

@IsaacSomething
Copy link

IsaacSomething commented Aug 2, 2018

Bug Report

Ionic Info

Ionic:

   ionic (Ionic CLI)  : 4.0.2 (C:\Users\<username>\AppData\Roaming\npm\node_modules\ionic)
   Ionic Framework    : ionic-angular 3.9.2
   @ionic/app-scripts : 3.1.11

Cordova:

   cordova (Cordova CLI) : 8.0.0
   Cordova Platforms     : none

System:

   NodeJS : v8.9.0 (C:\Program Files\nodejs\node.exe)
   npm    : 5.6.0
   OS     : Windows 10

Describe the Bug
Canceling after an ionic serve does not kill the process it was running on, and leads to massive memory leaking.

Steps to Reproduce
Steps to reproduce the behavior:

  1. ionic serve run the app and then ctrl + c to cancel
  2. Open task manager ( on windows ) and see the Node.js Server-side still running
  3. Repeat step one until computer memory is buggered :)

Related Code
No related code

Expected Behavior
Ctrl + c should kill the node process completely

Additional Context
You can also see this, when running ionic serve every subsequent serve will be spun up with the next port number

ionic-app-scripts serve --address 0.0.0.0 --port 8102 --livereload-port 35735 --dev-logger-port 53709 --nobrowser

Where the port number should be 8000

@ionitron-bot ionitron-bot bot added the triage label Aug 2, 2018
@imhoffd
Copy link
Contributor

imhoffd commented Aug 2, 2018

Thanks for the issue report!

Duplicate of ionic-team/ionic-cli#3401

@imhoffd imhoffd closed this as completed Aug 2, 2018
@baron554
Copy link

baron554 commented Aug 9, 2018

Experiencing this as well. Is there a fix for this?

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 9, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants